Support IBufferDistributedCache#593
Draft
Inok wants to merge 3 commits into
Draft
Conversation
Inok
force-pushed
the
buffer-cache
branch
2 times, most recently
from
c7f4df4 to
1b3c60b
Compare
Contributor
Author
|
Hi @jodydonetti, did you have a chance to look into this? If you need any additional context, please let me know. If the general direction feels right, I'd continue with the missing parts (mainly tests at this point IIRC) 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prototype of
IBufferDistributedCachesupport.Efficient buffered serialization requires a breaking change in the serializer's interface. I started with a different approach, introducing
IBufferFusionCacheSerializerinstead. It's backward-compatible and allows to opt out of this feature by those who use custom serializers.I haven't measured the overall perf carefully yet, but the serialization part looks promising: somewhat faster and with much less memory allocation.
That said, there are still things to improve (e.g., tests), and of course I'm not pushing with a separate interface. Breaking the existing
IFusionCacheSerializerand making v3 is also an option. Or it can be both: separate interface first, merge them later in v3.