WIP: Vinscant fixes - #130
Open
draxaris1010 wants to merge 4 commits into
Open
draxaris1010 wants to merge 4 commits into
draxaris1010 wants to merge 4 commits into
Conversation
such that the user has time to see that everything went well
hanneskt
approved these changes
Sep 15, 2026
|
|
||
| let mut num_retry = 0; | ||
| let mut should_retry = true; | ||
| while should_retry && num_retry < 5 { |
Member
There was a problem hiding this comment.
this is fine, but personally I think I would use a for _ in 0..5
and continue or break instead of the should retry, it's easier to reason about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.