Skip to content

feat(server): submit signed escrow calls and expose the relay in the hire endpoint (#96) - #132

Merged
TOMOKI977 merged 10 commits into
feat/96-escrow-relay-07-preparefrom
feat/96-escrow-relay-10-endpoint
Oct 8, 2026
Merged

TOMOKI977 merged 10 commits into
feat/96-escrow-relay-07-preparefrom
feat/96-escrow-relay-10-endpoint

Conversation

@moises-cisneros

@moises-cisneros moises-cisneros commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Refs #96

Part of the chain that replaces #119, split after its review. Tracker: #122. Regrouped from a first 12 PR split (#130, #131 were folded into this one).

Summary

The submit half and the public surface. submitEscrowCall checks the signed envelope against its preparation, stores a ChainSubmission as submitted and only then sends it; chain outcomes never throw and a repeated submit returns the existing record. createHire is idempotent per wallet and returns an unsigned create_job, and HireEscrowEffects.onJobCreated binds the job id once. HireEndpoint exposes it all behind requireLogin through an injectable SessionWallet (fails closed with AuthenticationUnavailable until #25). Regenerated endpoint and client.

Acceptance criteria

The chain as a whole covers #96; this PR carries its slice (see Scope below).

  • The app can create and fund a hire on testnet using only prepare… and submitEscrowCall (proven in the docs PR)
  • A signed envelope that differs from its preparation in any field is rejected
  • A caller can never prepare or submit for a hire that is not theirs
  • A submit… call never throws for chain outcomes
  • Each preparation has at most one ChainSubmission

Verification evidence

dart analyze --fatal-infos
dart test test/unit test/protocol test/spike test/ledger test/hire   -> 567 passed
dart test test/integration   -> 68 passed
serverpod generate leaves the tree unchanged (ignoring line endings)

Notes for reviewers

  • Review against the parent branch (feat/96-escrow-relay-07-prepare), not main. The commits are ordered to be read one by one.
  • Over the 400 line budget: 3097 authored lines, mostly tests of code that moves funds. Splitting further cuts the unit apart, so it needs size:exception.
  • Generated code, migrations and recorded fixtures are excluded from the authored count.

Chain Context

Field Value
Chain Escrow relay prepare and submit endpoints (#96)
Tracker PR #122
Position 3 of 4
Base feat/96-escrow-relay-07-prepare
Depends on #129
Follow-up #134
Review budget 3097 authored (3592 total) / 400
Starts at feat/96-escrow-relay-07-prepare
Ends with Submit side of EscrowRelayService, HireService, HireEscrowEffects, tracker wiring, HireEndpoint, HireServices, generated endpoint and client, with their tests.

Chain Overview

main
 └── #122 Tracker (draft, no merge)
      └── #126 escrow relay foundations: protocol, config, envelope codec and RPC
           └── #129 persist preparations and prepare unsigned escrow envelopes
                └── 📍 #132 submit signed escrow calls and expose the relay in the hire endpoint
                     └── #134 escrow relay API, ADRs, README, testnet e2e and OpenSpec archive

Scope

  • Includes: Submit side of EscrowRelayService, HireService, HireEscrowEffects, tracker wiring, HireEndpoint, HireServices, generated endpoint and client, with their tests.
  • Excludes: Docs and the e2e script.

Autonomy

  • CI is expected to pass for this PR branch
  • This PR has one deliverable scope
  • This PR can be rolled back without unrelated changes
  • Tests, docs, or manual verification cover this unit

submitEscrowCall checks the signed envelope against its preparation, stores a ChainSubmission as submitted and only then sends it. Chain outcomes never throw, and a repeated submit returns the existing record. Part of #96.
HireEscrowEffects.onJobCreated binds the job id once and opens the hire. Part of #96.
createHire returns the hire with an unsigned create_job, and a repeated requestId from the same wallet returns the same hire or IdempotencyKeyReused. Part of #96.
createHire, prepareCreateJob, prepareFund, prepareComplete, prepareReject and submitEscrowCall, each behind requireLogin through an injectable SessionWallet. The production default fails closed with AuthenticationUnavailable until wallet sessions land (#25). Regenerates the endpoint and client. Part of #96.
Lists ChainDataUnavailable for submitEscrowCall, drops the TypeScript sidecar from the ADRs and documents the config keys and the end-to-end run. Part of #96.
Runs the real endpoint, services, codec, RPC client and chain tracker against testnet. The consumer key stays in the process environment. Part of #96.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Deploying puls3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 772f554
Status:⚡️  Build in progress...

View logs

@TOMOKI977 TOMOKI977 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This slice is part of the code I reviewed in full on #119 at b0a4adc (all four lenses; see the review there). I checked that the tip of the chain matches b0a4adc except for the CI fix in .env.example and .gitleaks.toml (and main's #112). The follow-ups listed on #119 apply to the chain as a whole.

…-12-openspec

docs: escrow relay API, ADRs, README, testnet e2e and OpenSpec archive (#96)
@TOMOKI977
TOMOKI977 merged commit f28a32d into feat/96-escrow-relay-07-prepare Oct 8, 2026
1 check was pending
@TOMOKI977
TOMOKI977 deleted the feat/96-escrow-relay-10-endpoint branch October 8, 2026 19:36
TOMOKI977 pushed a commit that referenced this pull request Oct 8, 2026
Closes #96. Server-side relay (api.md Decision A): HireEndpoint with idempotent createHire, prepareCreateJob/prepareFund/prepareComplete/prepareReject that build unsigned Soroban envelopes, and submitEscrowCall that verifies the signed envelope byte for byte, checks the ed25519 signature against the session wallet, stores a submitted ChainSubmission and sends it for the chain tracker. Session wallet fails closed until #25. Includes the testnet e2e tool (tool/e2e_relay_testnet.dart), docs and the OpenSpec archive. Reviewed as #119; landed through the chain #126, #129, #132, #134.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants