Skip to content

feat(server): stellar envelope codec (#96) - #125

Closed
moises-cisneros wants to merge 2 commits into
feat/96-escrow-relay-02-xdr-encoderfrom
feat/96-escrow-relay-03-stellar-codec
Closed

moises-cisneros wants to merge 2 commits into
feat/96-escrow-relay-02-xdr-encoderfrom
feat/96-escrow-relay-03-stellar-codec

Conversation

@moises-cisneros

@moises-cisneros moises-cisneros commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Refs #96

Part of the chain that replaces #119, split after its review. Tracker: #122.

Summary

The stellar_dart implementation of EnvelopeCodec: decode, field by field comparison (contract, function, arguments, source, time bounds) and ed25519 verification. A spike proves the library decodes and re-encodes recorded testnet envelopes byte for byte. 708 of the lines are the codec test, with a test per field group.

Acceptance criteria

The chain as a whole covers #96; this PR carries its slice (see Scope below).

  • The app can create and fund a hire on testnet using only prepare… and submitEscrowCall (proven in the docs PR)
  • A signed envelope that differs from its preparation in any field is rejected
  • A caller can never prepare or submit for a hire that is not theirs
  • A submit… call never throws for chain outcomes
  • Each preparation has at most one ChainSubmission

Verification evidence

dart analyze --fatal-infos
dart test test/spike test/ledger/envelope_codec_test.dart

Notes for reviewers

  • Review against the parent branch (feat/96-escrow-relay-02-xdr-encoder), not main.
  • Over the 400 line budget: 1059 authored lines, mostly tests of code that moves funds. It is one cohesive unit and cannot shrink without dropping tests, so it needs size:exception.
  • Generated code, migrations and recorded fixtures are excluded from the authored count.

Chain Context

Field Value
Chain Escrow relay prepare and submit endpoints (#96)
Tracker PR #122
Position 3 of 12
Base feat/96-escrow-relay-02-xdr-encoder
Depends on #124
Follow-up #126
Review budget 1059 authored (1162 total) / 400
Starts at feat/96-escrow-relay-02-xdr-encoder
Ends with stellar_envelope_codec.dart, the stellar_dart and crypto dependencies, the spike, the codec test and recorded fixtures.

Chain Overview

main
 └── #122 Tracker (draft, no merge)
      └── #123 protocol
           └── #124 xdr-encoder
                └── 📍 #125 stellar-codec
                     └── #126 rpc-client
                          └── #127 preparation-store
                               └── #128 hire-lifecycle
                                    └── #129 prepare
                                         └── #130 submit
                                              └── #131 hire-service
                                                   └── #132 endpoint
                                                        └── #133 docs
                                                             └── #134 openspec

Scope

  • Includes: stellar_envelope_codec.dart, the stellar_dart and crypto dependencies, the spike, the codec test and recorded fixtures.
  • Excludes: RPC calls, stores, services.

Autonomy

  • CI is expected to pass for this PR branch
  • This PR has one deliverable scope
  • This PR can be rolled back without unrelated changes
  • Tests, docs, or manual verification cover this unit

…opes

Adds stellar_dart and crypto. The spike decodes recorded testnet envelopes, re-encodes them byte for byte and checks the network hash and the ed25519 signature. Part of #96.
Decodes a signed envelope, compares it field by field with its preparation (contract, function, arguments, source, time bounds) and verifies the signature. Part of #96.
@moises-cisneros

Copy link
Copy Markdown
Contributor Author

Folded into #126 to keep the chain at 4 PRs. The commits are the same, just grouped; this branch stays in the history of #126.

@moises-cisneros
moises-cisneros deleted the feat/96-escrow-relay-03-stellar-codec branch October 8, 2026 17:04

@TOMOKI977 TOMOKI977 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This slice is part of the code I reviewed in full on #119 at b0a4adc (all four lenses; see the review there). I checked that the tip of the chain matches b0a4adc except for the CI fix in .env.example and .gitleaks.toml (and main's #112). The follow-ups listed on #119 apply to the chain as a whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants