Repository navigation
feat(server): stellar envelope codec (#96) - #125
Closed
moises-cisneros wants to merge 2 commits into
Closed
moises-cisneros wants to merge 2 commits into
moises-cisneros wants to merge 2 commits into
Conversation
…opes Adds stellar_dart and crypto. The spike decodes recorded testnet envelopes, re-encodes them byte for byte and checks the network hash and the ed25519 signature. Part of #96.
Decodes a signed envelope, compares it field by field with its preparation (contract, function, arguments, source, time bounds) and verifies the signature. Part of #96.
This was referenced Oct 8, 2026
Contributor
Author
TOMOKI977
approved these changes
Oct 8, 2026
TOMOKI977
left a comment
Contributor
There was a problem hiding this comment.
Approved. This slice is part of the code I reviewed in full on #119 at b0a4adc (all four lenses; see the review there). I checked that the tip of the chain matches b0a4adc except for the CI fix in .env.example and .gitleaks.toml (and main's #112). The follow-ups listed on #119 apply to the chain as a whole.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #96
Part of the chain that replaces #119, split after its review. Tracker: #122.
Summary
The
stellar_dartimplementation ofEnvelopeCodec: decode, field by field comparison (contract, function, arguments, source, time bounds) and ed25519 verification. A spike proves the library decodes and re-encodes recorded testnet envelopes byte for byte. 708 of the lines are the codec test, with a test per field group.Acceptance criteria
The chain as a whole covers #96; this PR carries its slice (see Scope below).
prepare…andsubmitEscrowCall(proven in the docs PR)submit…call never throws for chain outcomesChainSubmissionVerification evidence
Notes for reviewers
feat/96-escrow-relay-02-xdr-encoder), notmain.size:exception.Chain Context
feat/96-escrow-relay-02-xdr-encoderfeat/96-escrow-relay-02-xdr-encoderstellar_envelope_codec.dart, thestellar_dartandcryptodependencies, the spike, the codec test and recorded fixtures.Chain Overview
Scope
stellar_envelope_codec.dart, thestellar_dartandcryptodependencies, the spike, the codec test and recorded fixtures.Autonomy