Feat/27 deploy flow UI

[Pericena]

Closes #27 (UI scope). Also covers part of #37 (Studio form validation) and a mobile-first UX pass, as discussed. Testnet end to end is blocked by #18 and #25 (see below).

Summary

1. Agent deploy flow (#27)

• Reusable DeployFlow for one AgentDraft, embeddable by the Agent Studio (feat: Agent Studio UI (builder, playground, deploy) #37) with no dependency on its form.
• Steps: preparing → waiting for signature → registering on-chain → activating → live (DeployStepper).
• Signing only through WalletPort. It refuses to sign a transaction prepared for a different account.
• Success: agent id, tx hash with a stellar.expert testnet link, copy buttons, and "Open agent" to /agent/:id.
• Errors with recovery and no reload: signature rejected, transaction failed (re-prepares), backend error, plus wallet unavailable, wrong network, account changed, connection lost/timeout and invalid response.
• DeployFlowController holds the logic: it never runs twice, resumes from the failed step and verifies every backend answer. DeployGateway is the port for the feat: register agent flow (wallet and on-chain identity) #18 endpoint; FakeDeployGateway stands in until it exists.

2. Mobile-first UX

• Bottom navigation on phones (Marketplace, Studio, Activity, Profile) with an unread badge.
• Compact phone type scale (14 px body, 18–28 px titles), 44 px buttons and denser inputs. Tap targets stay 48 px.
• Marketplace: search with a clear button, sort sheet, sideways skill chips, a "Top rated" carousel, compact cards, skeletons and an empty state.
• Activity feed and a wallet-first Profile (no passwords). Both are in memory until server endpoints exist.

3. Studio publishing rules (part of #37)

• ADR-0004 manifest rules: name 3–48 chars, description 10–280, prompt 20–8,000, 1–5 skills, price > 0.
• Inline errors, character counters, a "Ready to publish" checklist and agent policies that must be accepted before deploying.

4. Ratings and hire flow (on top of #92)

• Agent detail shows average rating, distribution and reviews. Rating stays locked until a real paid hire exists.
• feat(flutter): hire flow UI with escrow summary and error recovery (demo signing) #92's hire sheet kept as is. On top of it: plain-language wallet errors ("No funds moved"), a phone-friendly sheet, and fixes for two overflows at 390 px.

Acceptance criteria (#27)

• Each error state reproduced and recovered without reload (one test per error)
• Embeddable, no dependency on the Studio form
• Widget tests for every progress and error state with MockWallet and a fake client
• flutter analyze: 0 issues · flutter test: 141/141
• Testnet end to end + GIF + tx hash: blocked. There is no register/deploy endpoint yet (feat: register agent flow (wallet and on-chain identity) #18) and no real wallet adapter yet (feat: wallet connection in Flutter app #25). Wiring it means adding one DeployGateway implementation over the generated Serverpod client; no UI change is needed.

How to verify

cd puls3_flutter
flutter analyze && flutter test --concurrency=1

Then open the app through Serverpod at http://localhost:8082/app. Serverpod caches the app for 24 h, so hard-reload with Ctrl+Shift+R after a new build. Deploy an agent, then deploy again and reject the signature.

Notes for reviewers

• Size is above the 400-line budget, mostly tests and presentational widgets. Requesting size:exception.
• Merged with main, including feat(flutter): hire flow UI with escrow summary and error recovery (demo signing) #92 and feat(server): chain submission store, sendTransaction and tracker for create_job and fund #100. One feat(flutter): hire flow UI with escrow summary and error recovery (demo signing) #92 test needed the new AppScope fields; its behaviour is unchanged.
• For feat: wallet connection in Flutter app #25: WalletPort.signTransaction must return the signed XDR, because the server relays it (API contract docs: add API contract between Flutter app and Serverpod #77).

[cloudflare-workers-and-pages]

Deploying puls3 with    Cloudflare Pages

Latest commit:	a0c37cf
Status:	✅  Deploy successful!
Preview URL:	https://2efb1c77.puls3-4lw.pages.dev
Branch Preview URL:	https://feat-27-deploy-flow-ui.puls3-4lw.pages.dev

View logs

[TOMOKI977]

Thanks for this, it's a lot of careful work. The deploy controller is genuinely solid: it resumes from the failed step, keeps the prepared and signed transaction across a lost response (so a retry doesn't register the agent twice), and never runs twice. The error-state tests and the UX pass show real attention to detail.

I need to request changes, mostly so the app never claims something that didn't happen (the same rule we applied to #92):

Blocking

1. A production build shows a fake deploy as real. main.dart passes MockWallet() and no gateway, so app.dart falls back to FakeDeployGateway with no flag. The success screen says "Your agent is now live on Stellar" (deploy_copy.dart:86), the notification says the same (deploy_sheet.dart:45), and the stellar.expert link opens a fabricated hash. Please either gate the fake gateway behind an explicit demo flag, or label the result clearly as a demo (no "live on Stellar", no explorer link for a fake hash), like #92's "Demo signature only".

2. Closes #27 would close the issue with the testnet end-to-end criterion unmet. Our template asks for Refs #27 in that case, listing what's missing (you already explain it well in the body).

3. WalletPort.signTransaction still says "Signs and submits [unsignedXdr]. Returns the transaction hash." (wallet_port.dart:18), and MockWallet returns a hash that the controller passes to submitRegistration as the signed transaction. With the relay (api.md, Decision A) the wallet only signs and returns the signed XDR, and the server submits. The PR notes say this, but the code doesn't yet. A real adapter written to the current doc would submit on its own and bypass the relay. Since #25 is also yours, aligning the port now saves a rework.

4. Invented reputation is shown as real.

   • Seeded reviews default to verifiedHire: true, so made-up reviews carry the "Verified hire" badge (review_store.dart:12,129-153).
   • The Activity seed shows "Payment received" and "New 5-star rating" (notification_center.dart:87-111).
   • A newly deployed agent gets rating: 5.0 with zero reviews (deploy_sheet.dart:55, studio_screen.dart:196).

   Only the footer says "Demo build". Please mark seeded items as demo, drop the "Verified hire" badge from seeds, and start new agents at 0.0 (RatingBadge already hides 0).

5. Size. 58 files and ~5,200 lines across four concerns is too much to review safely, so I'd rather not grant size:exception. Suggested split, in merge order:

   • A. Theme and shell: puls3_theme.dart, breakpoint constants, content_width, primary_button, screen_header, skeleton_box, app_shell.
   • B. Deploy flow (#27): lib/src/deploy/*, ui/organisms/deploy/*, copyable_value_row, progress_step_row, deploy_sheet, the deploy_progress_view/success_panel cleanup, and their tests.
   • C. Studio publishing rules (#37): agent_draft, publish_checklist, agent_form, studio_screen, and their tests.
   • D. Mobile screens: market, activity, profile, notification center.
   • E. Ratings and reviews, last, once markHired is wired to a real hire.

For when the relay (#18, #96) is wired, not blocking now

• retry() only re-prepares after transactionFailed or accountChanged. The relay returns PreparationExpired and superseded preparations (api.md:103,117), which today fall into backendError and would retry the same expired XDR forever.
• DeployGateway doesn't match the documented deploy flow yet: there's no second signature for set_agent_wallet, no draftId on prepare, and no polling of the deploy session (api.md:149-172). So "no UI change needed" won't fully hold.
• connect() and signTransaction() have no timeout, and while busy the sheet can't be closed, so a wallet popup that never answers leaves the user stuck. There's also no cancellation if the flow is disposed mid-run.

Smaller things

• Validation counts UTF-16 code units (String.length), and the tests skip the exact boundaries (3/48, 10/280, 20/8000, 1 and 5 skills). A prompt over 8,000 shows "Write at least 20 characters", and systemPrompt is sent untrimmed.
• The checklist labels and profile messages repeat the limits as literals next to AgentDraftRules, so they will drift.
• Breakpoints (600/640/900/960) are repeated as raw numbers, and compactLayoutMaxWidth exists but isn't used everywhere.
• markHired is never called from lib/, so rating is unreachable in the app. SuccessPanel and AppScope.ids are now unused. The explorer URL is built inline instead of using stellarExpertTxUrl.
• Raw e.toString() is shown in the hire sheet error.
• PR hygiene: a conventional title such as feat(flutter): deploy flow UI with stepper and error recovery, labels (area: frontend, type: feat), and request reviewers.

Happy to pair on the split or the WalletPort change if useful.

[Pericena]

Thanks for the detailed review. I split the work as you suggested and applied the blocking fixes:

• feat(flutter): mobile-first theme and app shell #111 (A, theme and shell): breakpoints in one Puls3Breakpoints file instead of raw numbers, compact phone type scale, 44 px buttons, bottom nav. No screen content changes.
• Feat/27 deploy flow #112 (B, deploy flow, Refs #27), stacked on feat(flutter): mobile-first theme and app shell #111.

Blocking

1. Fake deploy shown as real: fixed in Feat/27 deploy flow #112. A demo banner shows during the flow; the result reads "Demo deploy only" with no "live on Stellar", no explorer link, no agent page and no made-up hash. Demo agents are not listed.
2. Closes #27: Feat/27 deploy flow #112 uses Refs #27 and lists what's missing (feat: register agent flow (wallet and on-chain identity) #18, feat(server): escrow relay prepare and submit endpoints for hires #96).
3. WalletPort: fixed in Feat/27 deploy flow #112. signTransaction signs and returns the signed XDR; the server submits. MockWallet returns a marked signed placeholder instead of a hash.
4. Invented reputation: new agents start at 0.0 in Feat/27 deploy flow #112. Seeded notifications and reviews (marked as demo, no "Verified hire") are handled in D and E.
5. Size: split into feat(flutter): mobile-first theme and app shell #111 and Feat/27 deploy flow #112. C (Studio publishing rules, feat: Agent Studio UI (builder, playground, deploy) #37), D (mobile screens) and E (ratings, last, once markHired is wired to a real hire) follow as separate PRs.

Relay notes, also handled in #112: re-prepare on PreparationExpired, a timeout for a wallet that never answers (the sheet can be closed while the wallet prompt is open), and cancellation if the flow is closed mid-run. Full DeployGateway alignment (set_agent_wallet, draftId, session polling) goes with #18/#96.

Smaller things: stellarExpertTxUrl, and SuccessPanel/AppScope.ids removed, in #112. Validation (character counting, exact-boundary tests, shared limits, trimmed prompt) goes in C. The hire sheet's raw e.toString() goes in D.

Closing this PR in favour of #111 and #112. Thanks for the offer to pair. I'll ping you on the C split if needed.

[TOMOKI977]

@Pericena this one is superseded by the split (#111 merged, #112 and #113 open). Could you close it so the review queue stays clear? Thanks!

[Pericena]

Closed in favor of #111 (merged), #112 and #113. Thanks!