Repository navigation
feat(participation): topic creation infrastructure, claim and migration 0004 (hackathon-participation 1a/3) - #43
Merged
Merged
Conversation
…assification and probe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 1a of 3 for change 4,
hackathon-participation. When an admin confirms, the bot creates a🏆 <name>forum topic, then posts and pins the analysis there.This PR adds only the infrastructure, with tests. Nothing uses it yet, so bot behavior is unchanged.
openspec/changes/hackathon-participation/.migrations/0004_hackathon_participation.sql: adds two columns and nothing else.topic_claim_untilholds the anti-duplicate claim andgeneral_message_idholds the General analysis message id.src/adapters/d1/hackathon-analysis-repo.ts:team_idwith bound parameters.ForumTopicManagerport andsrc/adapters/telegram/forum-topic-manager.ts:createclassifies the outcome as missing rights, not a forum, rejected, or uncertain.probeusessendChatActionwith the thread id. It reportsdeletedonly for a known thread-gone error; anything ambiguous counts as live, so a duplicate topic is never created.ChatPublisher:posttakes an optional{ participateSlug }, which adds the "✅ Participamos" button (hp:<slug>, at most 64 bytes).clearButtons.Review
A bounded review ran at high risk with all 4 lenses. There are no severe findings. Risk and resilience found nothing. Four advisory warnings will be fixed first thing in PR 1b:
ports.tscomment ended up detached fromChatPublisher.postdesign.mdand a comment say the claim expires at< now, but the code uses<= nowgeneralMessageIdacross a refreshsavereplaces the whole row, unlike the D1 upsertsTests
🤖 Generated with Claude Code