fix: hide window controls in web runtime#430
Open
ShowhyT wants to merge 2 commits into
Open
Conversation
Window control icons (minimize/maximize/close) rendered in the web runtime; now hidden there. Extract the visibility check into shouldShowWindowControls(), which uses window.zen.getAppInfo().runtime to detect web vs desktop, and add unit tests covering desktop, web, and mac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TitleBarrendered native window control buttons (minimize / maximize/ close) unconditionally on non-mac platforms. The buttons rendered
correctly with no visual issues, but they were non-functional when the
app is accessed as a web page served by the server: the click handlers
call Electron-only APIs (
windowMinimize,windowToggleMaximize,windowClose), and there is no native window to control in thatcontext.
Fix
shouldShowWindowControls(platform, runtime), a pure functionthat returns whether the controls should render (hidden on mac and
in the web runtime).
TitleBarnow useswindow.zen.getAppInfo().runtimeto detect theweb runtime, passed into
shouldShowWindowControlsalongside theexisting mac check.
shouldShowWindowControlscovering desktop(win/linux), web runtime, and mac.
Testing
npm test— new unit tests pass.behavior.
Scope
Limited to
TitleBar.tsxand its new test file; no other behaviorchanged.