fix: display leader key hints in lowercase to match actual keypresses#387
Open
kwame-Owusu wants to merge 2 commits into
Open
fix: display leader key hints in lowercase to match actual keypresses#387kwame-Owusu wants to merge 2 commits into
kwame-Owusu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When pressing the leader key (Space), the which-key overlay displayed key hints in uppercase (e.g., O, F, S) due to the CSS uppercase class on the key label elements. However, the matching logic expects lowercase input, pressing uppercase O (Shift+O) does not trigger the action, only lowercase o does.
This mismatch is confusing for users who see "O" in the overlay and naturally try pressing Shift+O.
Fix
Remove the uppercase CSS class from the key label in WhichKeyOverlay.tsx so the overlay displays keys exactly as they should be pressed (lowercase o, f, s, etc.). The "LEADER" prefix badge still uses its own uppercase class since that's a label, not a key to press.
Test
now the preview shows action keys in lowercase as per the screenshot
