Make Booth consumable from CMake - #156
Merged
Merged
Conversation
Zaneham
force-pushed
the
feat/cmake-package
branch
from
August 6, 2026 02:37
05b4562 to
145e487
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Booth had no install target, so a CMake project had no way to find it. This adds
make installand a package config, so downstream canfind_package(Booth)and build kernels withbooth_add_kernel().Doing that turned up
--amdgpuignoring-oand writing assembly to stdout with the register-plan line mixed into it, which is fixed here too (no-ostill means stdout, so nothing that pipes it breaks). There's a CI job building an example consumer against a staged install, and another checking the target list in the package config hasn't drifted from the flags main.c accepts.