Publish validation cases for the pressure vessel calculators#127
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
Code Review
This pull request adds detailed validation cases to the documentation for both the blind flange and pressure vessel dished end calculators, aligning the documentation with the automated test suite. The feedback suggests correcting the engineering nomenclature for the gasket seating bolt load (changing Wm1 to Wm2) and resolving a unit mismatch in the blank weight calculation formula to improve clarity.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71a9434270
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| follows the classical flange-bolting relation: | ||
|
|
||
| ``` | ||
| Wm1 = π·G·b·y = π · 250 · 12 · 11 ≈ 103 673 N |
There was a problem hiding this comment.
Correct the graphite gasket seating load
With the shipped calculator data, the Graphite gasket material uses y = 40 in static/utility-apps/blind-flange-calculator/assets/index-BJcMC13r.js, and the engine computes Wm1 as π·G·b·y. For the documented G = 250 mm and b = 12 mm case, selecting Graphite therefore gives about 376,991 N, not 103,673 N, so this validation case is not reproducible in the calculator despite the section saying users can compare digit for digit.
Useful? React with 👍 / 👎.
Closes #117
Adds a Validation cases section to the two calculators with a normative basis, using the exact fixtures from their unit-test suites (#96) as the single source of truth — the same numbers that gate CI in the app repos now serve as public evidence of correctness.
Dished End Calculator (3 cases)
Blind Flange Calculator (3 cases)
Each section states explicitly that these numbers run as unit tests on every engine change, so a release that breaks them cannot deploy — the trust argument the tool pages were missing.
Acceptance criteria
Verification
pnpm typecheck+ fullpnpm buildgreen (MDX validated, broken-link check passes)🤖 Generated with Claude Code