Skip to content

Publish validation cases for the pressure vessel calculators#127

Merged
YurMil merged 1 commit into
mainfrom
docs/validation-cases
Jul 20, 2026
Merged

Publish validation cases for the pressure vessel calculators#127
YurMil merged 1 commit into
mainfrom
docs/validation-cases

Conversation

@YurMil

@YurMil YurMil commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Closes #117

Adds a Validation cases section to the two calculators with a normative basis, using the exact fixtures from their unit-test suites (#96) as the single source of truth — the same numbers that gate CI in the app repos now serve as public evidence of correctness.

Dished End Calculator (3 cases)

  • DIN 28011 Klöpper, Da=1000/s=10/h1=40: R, r, dish depth (0.1935·Da − 0.455·s = 188.95 mm), total height, blank Ø 1170 mm, weight ≈ 84.4 kg — each with the hand calculation spelled out
  • DIN 28013 Korbbogen: 0.8·Da / 0.154·Da form factors, dish depth 248.65 mm, blank factor 1.14
  • Forming-thinning estimate: knuckle 12 % governs → 8.8 mm vs QC minimum 9.7 mm triggers the warning; suggested starting plate 11.5 mm

Blind Flange Calculator (3 cases)

  • PN class selection table (10→PN10 … 321→PN400, EN 1092-1 series)
  • Flat circular plate bending closed form: σ = 3PR²(3+ν)/(8t²) = 77.34 MPa and center deflection 0.170 mm for the P=1.6 MPa / R=125 / t=20 case; thickness solver verified as the exact inverse
  • Gasket seating bolt load Wm1 = π·G·b·y ≈ 103 673 N and the governing-case bolting check

Each section states explicitly that these numbers run as unit tests on every engine change, so a release that breaks them cannot deploy — the trust argument the tool pages were missing.

Acceptance criteria

  • At least 2 validation cases per covered calculator on its docs page
  • Cases generated from / consistent with the test fixtures (single source of truth)
  • Standard references included (DIN 28011/28013 form factors, EN 1092-1 PN series, classical plate theory)

Verification

  • pnpm typecheck + full pnpm build green (MDX validated, broken-link check passes)

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cadautoscript-com Ready Ready Preview, Comment Jul 20, 2026 7:35pm

@supabase

supabase Bot commented Jul 20, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project bkcimygtsnckzexbfqxh because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds detailed validation cases to the documentation for both the blind flange and pressure vessel dished end calculators, aligning the documentation with the automated test suite. The feedback suggests correcting the engineering nomenclature for the gasket seating bolt load (changing Wm1 to Wm2) and resolving a unit mismatch in the blank weight calculation formula to improve clarity.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/utilities/blind-flange-calculator.mdx
Comment thread docs/utilities/pressure-vessel-dished-end-calc.mdx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71a9434270

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

follows the classical flange-bolting relation:

```
Wm1 = π·G·b·y = π · 250 · 12 · 11 ≈ 103 673 N

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct the graphite gasket seating load

With the shipped calculator data, the Graphite gasket material uses y = 40 in static/utility-apps/blind-flange-calculator/assets/index-BJcMC13r.js, and the engine computes Wm1 as π·G·b·y. For the documented G = 250 mm and b = 12 mm case, selecting Graphite therefore gives about 376,991 N, not 103,673 N, so this validation case is not reproducible in the calculator despite the section saying users can compare digit for digit.

Useful? React with 👍 / 👎.

@YurMil
YurMil merged commit 4cb3401 into main Jul 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish validation cases for calculation engines on utility doc pages

1 participant