Conversation
Typed non-ASCII input (e.g. Vietnamese) was written to the SSH shell via Uint8List.fromList(data.codeUnits), which truncates each UTF-16 code unit to a single byte — corrupting any character above U+00FF so the server received garbage. Encode with Utf8Encoder at the user-text write sites (keystroke/IME, terminal.input hook, initialCommand, sendInput), matching the local-shell path and the existing payload encoder.
Add an inline path editor to the shared PathBreadcrumb: an edit affordance opens a text field seeded with the current path; Enter navigates there, Escape cancels. Wired into both the remote SFTP panel and the local file panel. Remote-typed paths are normalized to absolute POSIX with the trailing slash dropped so derived child paths don't double up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.1.35. Two changes on top of 0.1.34.
Added
PathBreadcrumb: edit affordance opens a text field seeded with the current path; Enter navigates, Escape cancels. Wired into both the remote SFTP panel and the local file panel; remote-typed paths normalized to absolute POSIX.Fixed
terminal.inputhook, startup command, snippet insert). Regression test added.Verification
flutter analyze— cleanflutter test test/services/ssh_service_open_shell_test.dart— 14/14 pass (incl. new UTF-8 regression test)