chore(build): remove unused asyncPool helper by YosefHayim · Pull Request #306 · YosefHayim/launch-store

YosefHayim · 2026-08-04T09:01:25Z

Summary

Deletes unused asyncPool.ts and its dedicated tests (production already uses Effect.forEach concurrency).
Retargets the CODE-STYLE concurrency example to plan/orchestrator.ts.
Refreshes generated test counts in README / docs / llms.txt.

Review focus

Slice of finding 11: remove dead concurrency helper; no runtime callers.

Test plan

Pre-commit typecheck + lint:style
CI green
Confirm no remaining runPooledWorkers imports

Summary by cubic

Remove unused async concurrency helper and its tests. Updated the code-style example to reflect Effect.forEach and synced test count badges; no runtime changes.

Refactors
- Delete src/core/build/asyncPool.ts and src/core/build/asyncPool.test.ts (no callers; Effect.forEach already used in production).
- Point the concurrency example in CODE-STYLE.md to src/core/plan/orchestrator.ts.
- Refresh test totals in READMEs, docs/commands.md, and llms.txt (2064 → 2056).

^{Written for commit dabd682. Summary will update on new commits.}

Why: Production code already uses Effect.forEach concurrency; asyncPool was dead surface with only its own tests. What: Delete asyncPool.ts and its tests; retarget CODE-STYLE concurrency example; refresh generated test counts in docs. Impact: Fewer tests (asyncPool suite gone); no runtime behavior change.

codeant-ai · 2026-08-04T09:01:30Z

🤖 CodeAnt AI — Review Status

Status	Commit	Started (UTC)	Finished (UTC)
✅ Reviewed your PR	`dabd682`	Aug 04, 2026 · 09:01	09:02

codeant-ai · 2026-08-04T09:01:31Z

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

changeset-bot · 2026-08-04T09:01:34Z

⚠️ No Changeset found

Latest commit: dabd682

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-08-04T09:01:37Z

Warning

Review limit reached

@YosefHayim, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c42a476-de09-49dd-bf8d-10a0548bb88e

📥 Commits

Reviewing files that changed from the base of the PR and between a57cdb1 and dabd682.

📒 Files selected for processing (14)

CODE-STYLE.md
README.de.md
README.es.md
README.fr.md
README.ja.md
README.ko.md
README.md
README.pt-BR.md
README.ru.md
README.zh-CN.md
docs/commands.md
llms.txt
src/core/build/asyncPool.test.ts
src/core/build/asyncPool.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

qodo-code-review · 2026-08-04T09:02:24Z

PR Summary by Qodo

Remove dead asyncPool helper and refresh concurrency/docs references

✨ Enhancement 🧪 Tests 📝 Documentation 🕐 10-20 Minutes

AI Description

• Delete unused asyncPool helper and its dedicated test suite (no runtime callers).
• Retarget concurrency style guidance to an in-use Effect.forEach example in orchestrator.
• Refresh README/docs test-count badges to reflect the removed tests.

Diagram

graph TD
  A["PR: remove asyncPool"] --> B["asyncPool.ts (deleted)"] --> C["asyncPool.test.ts (deleted)"]
  A --> D["CODE-STYLE.md"] --> E["orchestrator.ts (example)"]
  A --> F["READMEs/docs counts"]

High-Level Assessment

The approach (delete the unused helper and update references) is optimal given there are no runtime callers and the codebase already standardizes on Effect.forEach for concurrency. A softer approach (deprecate/keep) would add maintenance surface without clear benefit.

Files changed (12) +16 / -14

Documentation (12) +16 / -14

CODE-STYLE.mdRetarget concurrency example to orchestrator Effect.forEach usage +5/-3

Retarget concurrency example to orchestrator Effect.forEach usage

• Updates the concurrency guidance snippet to reference an in-use example in src/core/plan/orchestrator.ts. Keeps the contrast against Promise.all while emphasizing Effect-managed concurrency.

CODE-STYLE.md

README.de.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.de.md

README.es.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.es.md

README.fr.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.fr.md

README.ja.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.ja.md

README.ko.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.ko.md

README.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.md

README.pt-BR.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.pt-BR.md

README.ru.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.ru.md

README.zh-CN.mdUpdate tests badge count +1/-1

Update tests badge count

• Adjusts the generated tests-passing badge count to reflect removal of the asyncPool test suite.

README.zh-CN.md

commands.mdRefresh generated test count in command reference header +1/-1

Refresh generated test count in command reference header
• Updates the headline test-count figure used in the generated command reference to match the new total.
docs/commands.md

llms.txtRefresh test count in LLM index summary +1/-1

Refresh test count in LLM index summary
• Updates the documented test-count figure in the commands summary section to match the new total.
llms.txt

qodo-code-review · 2026-08-04T09:02:50Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

cubic-dev-ai

No issues found across 14 files

_{Re-trigger cubic}

codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Aug 4, 2026

cubic-dev-ai Bot reviewed Aug 4, 2026

View reviewed changes

YosefHayim added the domain:build Pipeline, distribution, build providers label Aug 4, 2026

Navigation Menu

chore(build): remove unused asyncPool helper - #306

chore(build): remove unused asyncPool helper#306
YosefHayim wants to merge 1 commit into
mainfrom
review/remove-async-pool

YosefHayim commented Aug 4, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

codeant-ai Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

codeant-ai Bot commented Aug 4, 2026

Uh oh!

changeset-bot Bot commented Aug 4, 2026

Uh oh!

coderabbitai Bot commented Aug 4, 2026

Review limit reached

Uh oh!

qodo-code-review Bot commented Aug 4, 2026

Uh oh!

qodo-code-review Bot commented Aug 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

YosefHayim commented Aug 4, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review focus

Test plan

Summary by cubic

Uh oh!

codeant-ai Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 CodeAnt AI — Review Status

Uh oh!

codeant-ai Bot commented Aug 4, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

changeset-bot Bot commented Aug 4, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Aug 4, 2026

Review limit reached

Uh oh!

qodo-code-review Bot commented Aug 4, 2026

PR Summary by Qodo

Uh oh!

qodo-code-review Bot commented Aug 4, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

YosefHayim commented Aug 4, 2026 •

edited by cubic-dev-ai Bot

Loading

codeant-ai Bot commented Aug 4, 2026 •

edited

Loading