refactor(cli): drop unused CLI compatibility facades - #305
Conversation
Why: CLI modules should only register Commander commands and call core programs; wizard/setup already import core directly. What: Remove runInit, runDoctor, chooseAccountInteractive, and setupIos re-exports from init/doctor/creds command modules. Impact: No user-facing change; thinner CLI boundary for finding 7.
|
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe CLI removes legacy credential, doctor, and init wrappers. Credential registration remains. The doctor command now maps required options and invokes ChangesCLI command surface
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by Qodorefactor(cli): drop unused CLI compatibility facade exports
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
Summary
runInit/runDoctor/chooseAccountInteractive/setupIosre-exports from thin CLI modules.Review focus
Finding 7 from the judgment review: keep
src/clias a thin boundary.Test plan
git greponly hits core program names)Summary by cubic
Removes unused CLI compatibility facades so command modules only register commands and hand off to core programs. No user-facing changes.
src/cli/commands:runInit,runDoctor,chooseAccountInteractive,setupIos.doctor,creds, andinitfocused on Commander registration andrunCliProgramonly.Written for commit 7622b65. Summary will update on new commits.
Summary by CodeRabbit