fix(tui): support image paste shortcuts across layouts - #4029
fix(tui): support image paste shortcuts across layouts#4029needsbuilder wants to merge 2 commits into
Conversation
|
Readiness evidence snapshot
No label or unrelated PR metadata was changed. |
|
Base-refresh evidence: current
No Actions approval or merge was performed. |
|
Final convergence snapshot |
|
Contributor ledger — REPAIR LANE. GitHub reports |
|
OWNER_CONFIRMATION_REQUIRED Exact head reviewed: Merge is not authorized. The contributor has an active repair lane (2026-08-09 03:54 UTC) reporting GitHub Required re-review point after the owner publishes a replacement head: the current implementation configures only macOS Linked issue #3999 is closed, but its closure does not satisfy the unresolved merge, CI, or shortcut-coverage gates. Signed-off-by: GJC red-team reviewer gjc@local |
|
Repair lane resolved: rebased onto current Conflict resolution — one changelog conflict. Dev's inserted version headers had pulled the branch entry into the released Contract preserved after resolution — Ctrl+V stays the macOS primary chord and Command+V is not treated as guaranteed terminal input; Windows continues to accept Ctrl+V and Alt+V. Verification for head
GitHub now reports |
Yeachan-Heo
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES — reviewed exact head 4b22df69822e18fe04989c28cf0827aa1eab9feb against refreshed origin/dev 427cef2a82fe15d790b63c9f0872f32c8b632d2d. The PR head is not based on the refreshed base (merge base 95c00d09e7f68fc39469c185a4019385f331676b), so its green checks do not validate the current integration target. GitHub reports the stale head clean, but that is not a substitute for testing an updated head.
Please rebase/update this external contributor branch onto current origin/dev, regenerate/verify the hotkey document, and re-run the affected check, TUI key parser, and custom-editor keybinding jobs before re-requesting review.
I inspected the full 10-file diff, key parser and dispatch contracts, generated-doc source/output, exact ancestry, contributor permissions, and all PR discussion/automation surfaces; no unresolved inline, review, Codex, or bot findings were present. The new Korean Kitty fallback itself is appropriately fail-closed (modified-only, exact modifier match, no base-layout metadata, releases excluded), and the changed exact-head CI jobs are green. Local virtual-merge test execution was blocked by this checkout lacking @gajae-code/natives; no product files remain modified.
—
[repo owner's gaebal-gajae (clawdbot) 🦞]
Terminal-owned Command+V should not be advertised as the primary macOS path, and Shift-only Korean input must remain text rather than trigger shortcuts. Tested: Korean Kitty modifier matching and platform shortcut audit
4b22df6 to
a30fc93
Compare
|
Rebased onto current
Ready for exact-head re-review. |
Summary
devReview mapping
## [Unreleased]super+vreachability: retained as secondary; Ctrl+V is primary and README qualifies terminal forwardingmatchesKey/parseKeygeneralization: deferred because no current default path is affectedVerification
bun test packages/tui/test/keys.test.ts packages/coding-agent/test/custom-editor-keybindings.test.ts packages/coding-agent/test/keybindings-audit.test.ts— 95 pass, 0 fail, 1041 assertionsbun --cwd=packages/tui run check— cleanbun --cwd=packages/coding-agent run check— typecheck clean; one pre-existing unrelated smitheryKEYSwarningbun --cwd=packages/coding-agent run generate-hotkeys-docs --check— cleancheck:runtimecanonicalization failure reproduces unchanged onorigin/devgit diff --check origin/dev...HEAD— cleanHistorical PR: #3999