Fix aria-labels and placeholder links (Issues #154, #155) - Tier 0 Bounty - #1
Open
YPC0813 wants to merge 1 commit into
Open
Fix aria-labels and placeholder links (Issues #154, #155) - Tier 0 Bounty#1YPC0813 wants to merge 1 commit into
YPC0813 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Issue INDIGOAZUL#154: Add aria-labels to icon buttons (25 LTD)
aria-label="Cerrar menú"to mobile drawer close button (line 1279)Issue INDIGOAZUL#155: Fix broken placeholder links (30 LTD)
href="#"links withdata-actionto<button>elements:<button class="more-menu-item">with aria-label<button class="mobile-drawer-item">with aria-labelhref="#"remaining in file<button data-action>patternVerification Answers
Issue INDIGOAZUL#154
Answer: 2 buttons
<button class="mobile-drawer-close">with<i class="fas fa-times">- Added aria-label<button class="mobile-fab">with<i class="fas fa-plus">- Already had aria-labelIssue INDIGOAZUL#155
Answer: 55 HTML files
Examples: home-dashboard.html, index.html, perfil.html, marketplace-social.html, lottery-predictor.html
Click action pattern:
<button data-action>(not<a onclick>)Definition of Done
aria-labelhref="#"placeholder links<a>to<button>