fix: remove world writable permissions from install folder and binary#544
Merged
Merged
Conversation
timbretimber
force-pushed
the
installer-perms2
branch
from
69ed915 to
3a820b5
Compare
luisangelsm
force-pushed
the
installer-perms2
branch
from
3a820b5 to
d00a37b
Compare
Member
|
@timbretimber Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the installer creates the app directory and binaries with world-writable permissions. This allows any unprivileged user to delete or otherwise modify the files. The default install location is under
%ProgramFiles%which is generally considered privileged and should only be written to by Administrators. Even if installing to another directory, using inherited permissions should cover any reasonable use case.Removing these additional permissions lets the directory and binaries inherit the the permissions set on
%ProgramFiles%.