Fix unreliable integration test directory cleanup#41
Merged
Conversation
Test setup/teardown used fs.rmdirSync, which fails when the target directory is not empty or no longer exists. That left stale artifacts between runs and made cleanup brittle. Use fs.rmSync with recursive and force so directories are removed reliably regardless of contents or prior existence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Test setup/teardown used fs.rmdirSync, which fails when the target directory is not empty or no longer exists. That left stale artifacts between runs and made cleanup brittle.
Use fs.rmSync with recursive and force so directories are removed reliably regardless of contents.
Context of Change
Type of Change
Before / After
Test Plan