RavenDBHealthCheck: prevent health check from disposing shared client certificate.#2467
Open
poissoncorp wants to merge 1 commit intoXabaril:masterfrom
Open
RavenDBHealthCheck: prevent health check from disposing shared client certificate.#2467poissoncorp wants to merge 1 commit intoXabaril:masterfrom
poissoncorp wants to merge 1 commit intoXabaril:masterfrom
Conversation
poissoncorp
force-pushed
the
RavenDB-25931
branch
from
855b7f0 to
34256ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Health check doesn't own the certificate lifetime; it may be shared (e.g. DI/KeyVault). Disposing it can break other RavenDB stores in the process.
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #2466
Special notes for your reviewer:
Used RavenDB store convention to disable disposing certificate.
Does this PR introduce a user-facing change?:
No
Please make sure you've completed the relevant tasks for this PR, out of the following list: