Migrate HealthChecks.ClickHouse to use official ClickHouse client library#2441
Closed
smbecker wants to merge 1 commit intoXabaril:masterfrom
Closed
Migrate HealthChecks.ClickHouse to use official ClickHouse client library#2441smbecker wants to merge 1 commit intoXabaril:masterfrom
smbecker wants to merge 1 commit intoXabaril:masterfrom
Conversation
Contributor
Author
|
Duplicate of #2431 |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2441 +/- ##
==========================================
+ Coverage 66.88% 67.29% +0.41%
==========================================
Files 268 254 -14
Lines 8730 8477 -253
Branches 631 602 -29
==========================================
- Hits 5839 5705 -134
+ Misses 2723 2608 -115
+ Partials 168 164 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The unofficial
ClickHouse.Clientrepo was recently archived and migrated to the new officialClickHouse.Driverlibrary. This PR migrates to the new official library.Does this PR introduce a user-facing change?: It is a breaking change that migrates from a now archived and unsupported library to the new official client library.
Please make sure you've completed the relevant tasks for this PR, out of the following list: