Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions transport/internet/grpc/config_test.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
package grpc

import (
"context"
"reflect"
"testing"

"github.com/stretchr/testify/assert"
"github.com/xtls/xray-core/common/net"
"github.com/xtls/xray-core/transport/internet"
"github.com/xtls/xray-core/transport/internet/stat"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
)
Expand Down Expand Up @@ -127,3 +131,17 @@ func TestSetUserAgent(t *testing.T) {
setUserAgent(conn, ua)
assert.Equal(t, ua, reflect.ValueOf(conn).Elem().FieldByName("dopts").FieldByName("copts").FieldByName("UserAgent").String())
}

func TestListenUnixRejectsIPAddress(t *testing.T) {
settings := &internet.MemoryStreamConfig{
ProtocolSettings: &Config{},
}

var listener internet.Listener
var err error
assert.NotPanics(t, func() {
listener, err = Listen(context.Background(), net.AnyIP, net.Port(0), settings, func(stat.Connection) {})
})
assert.Nil(t, listener)
assert.ErrorContains(t, err, "invalid unix listen")
}
3 changes: 3 additions & 0 deletions transport/internet/grpc/hub.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ func Listen(ctx context.Context, address net.Address, port net.Port, settings *i
grpcSettings := settings.ProtocolSettings.(*Config)
var listener *Listener
if port == net.Port(0) { // unix
if !address.Family().IsDomain() {
return nil, errors.New("invalid unix listen: ", address).AtError()
}
listener = &Listener{
handler: handler,
local: &net.UnixAddr{
Expand Down
Loading