Skip to content

Sockopt: Fix indentation of the CustomSockopt block for linux - #6568

Open
patterniha wants to merge 2 commits into
mainfrom
fix-custom
Open

Sockopt: Fix indentation of the CustomSockopt block for linux#6568
patterniha wants to merge 2 commits into
mainfrom
fix-custom

Conversation

@patterniha

@patterniha patterniha commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

#6564 (comment)

Closes #6564
Closes #6602

@patterniha

Copy link
Copy Markdown
Collaborator Author

also @RPRX can you check #716 (comment)

@Fangliding

Copy link
Copy Markdown
Member

我说了大不了我下次顺带改了
这么简单的事情还要copilot。。。

@Fangliding Fangliding closed this Aug 1, 2026
@patterniha

patterniha commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator Author

No, I didn't use copilot.
my GoLand-IDE automatically add extra space that cause check-format-test in Actions failed.
then I accidentally clicked "Fix with Copilot" before reading the error, then i stopped it immediately (you can see "The session was cancelled by the user" message)

i remove space myself and everything is OK now.

@patterniha patterniha reopened this Aug 1, 2026
@patterniha

patterniha commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator Author

my GoLand-IDE automatically add extra space that cause check-format-test in Actions failed.

the format-checker is added in d43a808

although I can turn off auto-add-space in my GoLand-IDE, but automatically adding spaces makes it easier for you to find where to write the next line of code and makes writing code much easier.

so i don't want to turn off auto-add-space feature in my GoLand-IDE, and removing spaces line by line before committing is very troublesome, the format-checker should be changed.

@KobeArthurScofield @Fangliding

also, Xray-core is still on Microsoft's list of suspicious apps, does anyone want to do something? in addition to fragment, it may have negatively affected other parts as well.
#4427 (comment)

@RPRX

RPRX commented Aug 12, 2026

Copy link
Copy Markdown
Member

@Fangliding 可以 merge 吗

@Fangliding

Copy link
Copy Markdown
Member

就是一些无所谓的typo而已应该问题不大

@patterniha

Copy link
Copy Markdown
Collaborator Author

also @RPRX can you check #716 (comment)

Two PRs in v2rayN/v2rayNG are waiting for your approval on the short name for cipherSuites in share-link standard.

@RPRX

@Fangliding

Fangliding commented Aug 12, 2026

Copy link
Copy Markdown
Member

cipherSuites不是什么广泛使用的参数 在默认的utls甚至会被无视 就为了个可能不知道多久后就会没的小绕过规则专门去加个这个 不应该

@patterniha

patterniha commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

I use cs for cipherSuites in my PattNG, This solved the problems of many Iranians who were using CDN.
It get 246 stars in a short period of time.

Many people create codes that add cs to share-links for use in PattNG for convenience:
https://ArasTey.github.io/cf-optimizor
https://darknessshade.github.io/PattNG-Config-Processor/
https://hidden-node.github.io/proxy-builder/
https://cherk-nevis.github.io/PattConfig/
https://amiralysaleh.github.io/V2ray-SubManager/
https://github.com/Awhiteowl/config-forge/tree/main
https://github.com/hamedp-71/Hamedvpn-CF
...

But cs must be added at the panels from the very beginning, and all iOS and Windows apps must support it.

For more than two weeks this method has worked miraculously.
Also, adding an abbreviation I don't think would hurt anyone.

@Graveyard9988

Copy link
Copy Markdown

Hi @RPRX and @Fangliding,

I would like to share a few logical and technical reasons why implementing the cs abbreviation for cipherSuites is highly beneficial for the ecosystem, especially for users under restricted network environments:

  1. Link Length & QR Code Usability:
    In many client applications, configurations are shared via QR codes. Shorter URIs generate lower-density QR codes, which are significantly faster to scan and less prone to read errors on low-end mobile devices. Abbreviating cipherSuites to cs saves critical bytes in the URI query string.

  2. Backward Compatibility:
    Adding cs as an optional alias does not introduce any breaking changes. Existing configs using cipherSuites will continue to work perfectly, making this a zero-risk enhancement.

  3. Preventing Ecosystem Fragmentation:
    Many community tools (like PattNG, config generators, and custom panels) have already adopted cs due to necessity. Standardizing this in the official core/spec prevents fragmentation and ensures a unified standard across different client implementations (such as v2rayN, v2rayNG, etc.).

We highly appreciate your time and endless efforts in maintaining this project. Could we please consider this small but highly impactful addition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix typo: "Syetem" should be "System" in transport_sockopt.go [Bug] customSockopt is ignored for inbound UDP sockets on Linux

4 participants