Skip to content

docker: ensure npm global CLIs are on PATH in image build - #92

Merged
SFangYy merged 1 commit into
masterfrom
ci
Jul 2, 2026
Merged

docker: ensure npm global CLIs are on PATH in image build#92
SFangYy merged 1 commit into
masterfrom
ci

Conversation

@SFangYy

@SFangYy SFangYy commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

ensure npm global CLIs are on PATH in image build

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

docker build -f Dockerfile -t localhost/picker:latest

Checklist:

  • My code follows the style guidelines of this project
  • I have added the appropriate labels
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Docker image build so that Node installed via nvm exposes globally installed npm CLI executables on PATH, improving usability of npm global tools inside the built image.

Changes:

  • Moves the nvm/Node installation step later in the Dockerfile (after building/installing Picker).
  • Adds a current symlink for the active Node version and prepends its bin/ directory to PATH so global npm CLIs resolve correctly.
  • Keeps /usr/local/bin symlinks for node, npm, and npx.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Dockerfile
Comment thread Dockerfile
@SFangYy
SFangYy merged commit 12a91d5 into master Jul 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants