ci: Use a separate benchmark filter - #7919
Open
mathbunnyru wants to merge 3 commits into
Open
Conversation
mathbunnyru
added
Ready to merge
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bthomee
reviewed
Jul 30, 2026
| # `install` target does not build them. | ||
| - name: Run the benchmarks | ||
| if: ${{ !inputs.build_only && runner.os != 'Windows' && env.SANITIZERS_ENABLED == 'false' && env.COVERAGE_ENABLED != 'true' && env.VOIDSTAR_ENABLED != 'true' }} | ||
| if: ${{ !inputs.build_only && runner.os != 'Windows' && inputs.build_type != 'Debug' && env.SANITIZERS_ENABLED == 'false' && env.COVERAGE_ENABLED != 'true' && env.VOIDSTAR_ENABLED != 'true' }} |
Collaborator
There was a problem hiding this comment.
- How about adding a new entry to the strategy matrix,
benchmark, that defaults to false, and is only set to true in the specific configs you want them to run? - Alternatively, only run the benchmark for configs for which a package is built?
Contributor
Author
There was a problem hiding this comment.
Added a separate benchmark, thanks for suggestion!
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the reusable CI build/test workflow so benchmark smoke-runs are skipped for Debug builds, aligning benchmark execution with its intent as a lightweight correctness check (not a performance run) and avoiding the extra runtime cost of Debug artifacts.
Changes:
- Skip the “Run the benchmarks” step when
inputs.build_typeisDebug. - Update the surrounding workflow comments to document the additional skip condition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mathbunnyru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Doesn't make sense running benchmarks in debug builds
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)