Make the package pip-installable - #17
Open
louislelay wants to merge 3 commits into
Open
louislelay wants to merge 3 commits into
louislelay wants to merge 3 commits into
Conversation
…cikit-build-core - Vendor prebuilt PXREARobotSDK binaries (linux x86_64/aarch64, windows amd64) and headers from upstream commit 85bac4d under vendor/ - Replace setup.py + setup scripts with pyproject.toml (scikit-build-core) - Repackage as xrobotoolkit_sdk package with _core extension, rpath $ORIGIN on Linux and os.add_dll_directory on Windows - Add cibuildwheel workflow (manylinux_2_34, cp310+) with PyPI trusted publishing - Update README and CLAUDE.md build instructions Co-authored-by: Cursor <cursoragent@cursor.com>
…indows link) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
cc @zhigenzhao @SherwinDengxiong for visibility |
|
@louislelay Thank you for this PR! I tested on Windows 11.
uv run python works, but pip install failed because of the Python version difference. |
|
It also happened on Linux. It seems Then is it possible to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Enable
pip install xrobotoolkit-sdk/uv add xrobotoolkit-sdkfrom PyPI, and reduce the from-source install togit clone+uv sync, meaning no more manual SDK download, build scripts, or copying headers around.How
The key enabler: upstream XRoboToolkit-PC-Service already ships prebuilt
PXREARobotSDKbinaries for every supported target. This PR vendors them (Linux x86_64/aarch64, Windows amd64, commit85bac4d, seevendor/README.md) so the build is fully self-contained, then modernizes the packaging around that:setup.py+ the three platform setup scripts are replaced bypyproject.tomlwith scikit-build-core; uv-first workflow (uv sync,uv build,uv.lock, Python 3.13 pinned,requires-python >= 3.10).xrobotoolkit_sdk._coreinside a regular package that bundles the vendored lib next to it (rpath$ORIGINon Linux,os.add_dll_directoryon Windows). Public API is unchanged.v*tags.Verification
CI on this PR builds all wheels and smoke-tests
import xrobotoolkit_sdkon each platform (this exercises the bundled-library loading). Artifacts are attached to the workflow run for manual testing.