Add Monopoly ruleset variants#260
Open
serrebidev wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds host-selectable US Classic, UK Waddingtons Classic, UK Short Game, UK Time Limit Game, and US Speed Die profiles.
The implementation uses the official rules from the start: the Waddingtons rules for the UK variants and Hasbro rules for Speed Die.
Details
Validation
cd server && uv run pytest tests/test_monopoly.py -q(43 passed)uvx ruff check server/games/monopoly/game.py server/tests/test_monopoly.py(passed)Root cause
Bus and three-of-a-kind advanced the game to the choice phase but only added a turn-menu action. The input menu was never requested automatically. The regression test now asserts that the player receives the encoded, selectable white-die/total menu, can resolve it through the normal menu event flow, and receives it again after reconnecting to a restored table.