Refresh mod map markers with Wynncraft API data#434
Closed
DeTosis wants to merge 2 commits into
Closed
Conversation
Member
|
The crowd sourced file should only contain the crowd sourced version, we already have a script that updates from the Wynncraft API, it has an open pull request currently #383, any pois that are not present in the API should be added to https://github.com/Wynntils/Static-Storage/blob/main/Data-Storage/services_missing.json |
Member
|
I'll close this as our crowd sourced version is pretty much up to date now as far as I can tell. But still feel free to add any missing pois to https://github.com/Wynntils/Static-Storage/blob/main/Data-Storage/services_missing.json and perhaps we can swap back to using the API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data for markers was retrieved from
api.wynncraft.com/v3/map/locations/markersand converted to the format required by the mod