Tests: Document value comparisons in post tests - #13939
Closed
noruzzamans wants to merge 2 commits into
Closed
noruzzamans wants to merge 2 commits into
noruzzamans wants to merge 2 commits into
Conversation
noruzzamans
marked this pull request as ready for review
October 2, 2026 18:45
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
wporg-sync
pushed a commit
that referenced
this pull request
Oct 2, 2026
Explain why post lookup, metadata, post type label, and attachment count tests retain `assertEquals()` when comparing separately constructed or cached objects by value. Developed in: #13939 Props noruzzaman. See #64895. git-svn-id: https://develop.svn.wordpress.org/trunk@64071 602fd350-edb4-49c9-b593-d223f7449a82
Member
|
PR #13939 landed in https://core.trac.wordpress.org/changeset/64071 |
wporg-sync
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 2, 2026
Explain why post lookup, metadata, post type label, and attachment count tests retain `assertEquals()` when comparing separately constructed or cached objects by value. Developed in: WordPress/wordpress-develop#13939 Props noruzzaman. See #64895. Built from https://develop.svn.wordpress.org/trunk@64071 git-svn-id: http://core.svn.wordpress.org/trunk@63230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reviewed
tests/phpunit/tests/post/for ticket #64895.There are 6 calls to
assertEquals()across 4 files:tests/phpunit/tests/post/getPageByPath.php:$page(WP_Post) with object returned fromget_page_by_path( 'some-page' ).$other_att(WP_Post) with object returned fromget_page_by_path( 'some-other-page' ).tests/phpunit/tests/post/meta.php:$mobj(stdClass) with database row object returned fromget_post_meta_by_id( $mid ).$mobj(stdClass) with database row object returned fromget_post_meta_by_id( $mid ).tests/phpunit/tests/post/types.php:$beforelabels object (stdClass) with$afterlabels object after callingget_post_type_labels().tests/phpunit/tests/post/wpCountAttachments.php:$expectedobject with cached object returned fromwp_cache_get( $cache_key, 'counts' ).All 6 calls intentionally compare object instances by value:
get_page_by_path()queries the database and instantiates aWP_Postobject, which is a separate instance from fixture references in the test.get_post_meta_by_id()constructs a database row object, distinct from the manually constructed$mobjfixture.get_post_type_labels()casts the labels array to a fresh(object), producing a distinct instance from$before.WP_Object_Cache::get()intentionally clones objects upon cache retrieval, returning a distinct instance in memory from$expected.In accordance with maintainer guidance on Trac #64895 (comments 88 & 93), these intentional loose comparisons are preserved and documented with:
// Keep assertEquals() because the objects are intentionally compared by value.Testing Instructions
Trac ticket: https://core.trac.wordpress.org/ticket/64895
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.