Users: Preserve early-authenticated user ID in determine_current_user filter chain - #12789
Users: Preserve early-authenticated user ID in determine_current_user filter chain#12789himanshupathak95 wants to merge 5 commits into
determine_current_user filter chain#12789Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…`determine_current_user` filters
9ce68b9 to
ed7f105
Compare
Trac ticket: https://core.trac.wordpress.org/ticket/28212
When a callback registered on the determine_current_user filter at a priority lower than 10 authenticates a user and returns a user ID, wp_validate_auth_cookie (hooked directly at priority 10) receives that user ID as its $cookie argument.
Because wp_validate_auth_cookie expected a cookie string, it failed parsing and returned false, overriding the user ID determined by the earlier filter callback.
Since we cannot wrap wp_validate_auth_cookie in a new filter callback function (like wp_validate_logged_in_cookie) because changing the hook name in default-filters.php would break backward compatibility for countless stateless API plugins that rely on remove_filter( 'determine_current_user', 'wp_validate_auth_cookie' ).
Instead, this PR adds a safeguard inside wp_validate_auth_cookie() in pluggable.php. If a user ID (non-string or numeric value) is passed, it returns it immediately. If no user ID is passed, it falls through to wp_parse_auth_cookie(), preserving the existing is_ssl() auto-detection logic perfectly.