Media: Require image dimensions for auto-sizes - #12553
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This PR addresses an image-height regression reported in WordPress 6.7.1 when an image uses
sizes="auto"without bothwidthandheightattributes. The enlargedcontain-intrinsic-size: 3000px 1500pxworkaround added for #62413 can cause incomplete image markup to receive a 1500px intrinsic height. This is visible while lazy-loaded images are waiting to load and can produce significant layout distortion.Trac ticket: https://core.trac.wordpress.org/ticket/62515
Images with valid dimensions retain the larger intrinsic-size workaround introduced for #62413. Images without complete dimensions instead use the browser’s standard fallback and no longer receive WordPress’s 1500px intrinsic height.
This change does not attempt to infer or reconstruct a missing image aspect ratio. If a theme or plugin removes dimensions after Core generates the markup, the CSS guard prevents WordPress’s enlarged fallback from applying, but the browser must still use its standard fallback.
Author CSS that explicitly overrides the mapped aspect ratio, such as aspect-ratio: auto, is outside the scope of this change.
Use of AI Tools
AI assistance: Yes
Tool(s): Pi
Model(s): GPT-5.6
Used for: Initial code skeleton and test suggestions and code review; final implementation and tests were reviewed and edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.