Tighter probe + force temp_store=MEMORY under Turso

Two changes in one CI iteration to maximize use of the build:

- Tighten the correlated-subquery probe: the minimal repro passed
  every workaround variant on Turso, so the bug isn't fundamental.
  Replace it with a probe that mirrors the *exact* shape the driver
  emits — info_schema-style _ist/_isc/sqlseq tables, the multi-table
  LEFT JOIN inside the correlated subquery, and COALESCE — then run
  the failing-test query patterns (`AI > 3`, `AI IS NULL`, plain
  SELECT) and print the actual rows so we can see what Turso returns.

- Patch the SQLite connection's __construct to issue
  `PRAGMA temp_store = MEMORY` after journal_mode setup. Turso's
  default disk-backed temp pager has a state-dependent
  `short read on page N` bug (mid-suite, doesn't reproduce in fresh
  PDO). Forcing temp_store=MEMORY routes temp tables through MemoryIO,
  which is the same code path the probe exercises and which works.
  This is the candidate fix for testCreateTemporaryTable +
  testTemporaryTableHasPriorityOverStandardTable.

Author: JanJakes

.github/workflows/phpunit-tests-turso.yml

@@ -1014,40 +1014,53 @@ jobs:
         run: |
           php <<'PHP'
           <?php
-          // Minimal repro of testInformationSchemaTablesFilterByAutoIncrement.
-          // Verify whether Turso correctly evaluates a correlated subquery
-          // alias inside a derived-table SELECT list when the outer query
-          // applies WHERE on the alias.
+          // Reproduce testInformationSchemaTablesFilterByAutoIncrement's exact
+          // shape — info_schema-style tables and the *exact* translate_table_ref
+          // correlated subquery (LEFT JOIN inside subquery + COALESCE).
           $pdo = new PDO('sqlite::memory:');
           $pdo->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
-          $pdo->exec('CREATE TABLE outer_t (id INT, name TEXT)');
-          $pdo->exec('CREATE TABLE inner_t (parent_name TEXT, value INT)');
-          $pdo->exec("INSERT INTO outer_t VALUES (1,'a'), (2,'b'), (3,'c')");
-          $pdo->exec("INSERT INTO inner_t VALUES ('a',10), ('b',20), ('c',30)");
+          // Mirror the driver's information schema layout and seed it.
+          $pdo->exec("CREATE TABLE _ist (table_schema TEXT, table_name TEXT, engine TEXT)");
+          $pdo->exec("CREATE TABLE _isc (table_schema TEXT, table_name TEXT, column_name TEXT, extra TEXT)");
+          $pdo->exec("INSERT INTO _ist VALUES ('main','low','InnoDB'), ('main','high','InnoDB'), ('main','plain','InnoDB')");
+          $pdo->exec("INSERT INTO _isc VALUES ('main','low','id','auto_increment'), ('main','high','id','auto_increment'), ('main','plain','id','')");
+          // sqlite_sequence is auto-managed; emulate with a regular table called sqlseq.
+          $pdo->exec("CREATE TABLE sqlseq (name TEXT, seq INT)");
+          $pdo->exec("INSERT INTO sqlseq VALUES ('low',1), ('high',5)");
+
+          // Driver's actual correlated subquery shape:
+          $corr = "(SELECT COALESCE(s.seq + 1, 1)
+                    FROM _isc AS c
+                    LEFT JOIN sqlseq AS s ON s.name = c.table_name
+                    WHERE c.extra = 'auto_increment'
+                    AND c.table_schema = t.table_schema
+                    AND c.table_name = t.table_name)";
+
+          $derived = "(SELECT table_name AS NAME, $corr AS AI FROM _ist AS t)";
 
           $cases = [
-              'baseline: correlated subq, no derived-table wrap' =>
-                  "SELECT id, (SELECT value FROM inner_t WHERE parent_name = outer_t.name) AS v FROM outer_t WHERE (SELECT value FROM inner_t WHERE parent_name = outer_t.name) > 15",
-              'derived-table wrap + WHERE on alias' =>
-                  "SELECT id FROM (SELECT id, name, (SELECT value FROM inner_t WHERE parent_name = outer_t.name) AS v FROM outer_t) WHERE v > 15",
-              'derived-table + WHERE on alias + outer col aliased in inner WHERE (length trick)' =>
-                  "SELECT id FROM (SELECT id, name, (SELECT value FROM inner_t WHERE parent_name = outer_t.name AND length(outer_t.name) > 0) AS v FROM outer_t) WHERE v > 15",
-              'derived-table + WHERE on alias + outer col added in inner SELECT (zero arith)' =>
-                  "SELECT id FROM (SELECT id, name, (SELECT value + (length(outer_t.name) - length(outer_t.name)) FROM inner_t WHERE parent_name = outer_t.name) AS v FROM outer_t) WHERE v > 15",
-              'derived-table + WHERE on alias + outer col combined into expression' =>
-                  "SELECT id FROM (SELECT id, name, (SELECT value || '|' || outer_t.name FROM inner_t WHERE parent_name = outer_t.name) AS combined, (SELECT value FROM inner_t WHERE parent_name = outer_t.name) AS v FROM outer_t) WHERE v > 15",
-              'derived-table + WHERE on alias + recreate as JOIN form' =>
-                  "SELECT id FROM (SELECT outer_t.id, outer_t.name, inner_t.value AS v FROM outer_t LEFT JOIN inner_t ON inner_t.parent_name = outer_t.name) WHERE v > 15",
+              'inline correlated subq value' =>
+                  "SELECT table_name, $corr AS AI FROM _ist AS t",
+              'derived-table + WHERE AI > 3 (the bug)' =>
+                  "SELECT NAME FROM $derived WHERE AI > 3",
+              'derived-table + WHERE AI IS NULL' =>
+                  "SELECT NAME FROM $derived WHERE AI IS NULL",
+              'derived-table + plain SELECT' =>
+                  "SELECT NAME, AI FROM $derived",
+              'derived-table + WHERE on AI with length(t.name) > 0 forced' =>
+                  ("SELECT NAME FROM (SELECT table_name AS NAME, "
+                   . "(SELECT COALESCE(s.seq + 1, 1) FROM _isc AS c "
+                   . "LEFT JOIN sqlseq AS s ON s.name = c.table_name "
+                   . "WHERE c.extra='auto_increment' "
+                   . "AND c.table_schema = t.table_schema "
+                   . "AND c.table_name = t.table_name "
+                   . "AND length(t.table_name) > 0) AS AI FROM _ist AS t) WHERE AI > 3"),
           ];
           foreach ($cases as $label => $sql) {
               try {
                   $rows = $pdo->query($sql)->fetchAll(PDO::FETCH_NUM);
-                  $ids = array_column($rows, 0);
-                  sort($ids);
-                  $got = json_encode($ids);
-                  $expected = '[2,3]';
-                  $tag = $got === $expected ? 'OK  ' : 'BUG ';
-                  echo "$tag $label  got=$got expected=$expected\n";
+                  $rows_pretty = array_map(fn($r) => '['.implode(',', array_map(fn($v) => $v === null ? 'NULL' : $v, $r)).']', $rows);
+                  echo "ROW  $label  =>  " . implode(' ', $rows_pretty) . "\n";
               } catch (Throwable $e) {
                   echo "FAIL $label -> " . $e->getMessage() . "\n";
               }
@@ -1882,6 +1895,40 @@ jobs:
           src = src.replace(old_c, new_c, 1)
           open(path, 'w').write(src)
           print('patched testCreateTableWithDefaultExpressions PRAGMA expectations for Turso')
+
+          # 20. testCreateTemporaryTable / testTemporaryTableHasPriorityOverStandardTable
+          #     fail mid-suite under Turso with `I/O error: short read on
+          #     page N` from the pager. With the default temp_store
+          #     setting Turso creates a per-connection temp database on
+          #     disk (via `tempfile::tempdir()` in core/connection.rs).
+          #     The CI probe of the same SQL on a fresh PDO passes because
+          #     the test order/state in the suite hits a code path the
+          #     probe doesn't. Force `temp_store = MEMORY` at connection
+          #     setup so temp tables go through MemoryIO instead, bypassing
+          #     the buggy disk-temp pager path.
+          path = 'src/sqlite/class-wp-sqlite-connection.php'
+          src = open(path).read()
+          old_jm = (
+              "\t\tif ( $journal_mode && in_array( $journal_mode, self::SQLITE_JOURNAL_MODES, true ) ) {\n"
+              "\t\t\t$this->query( 'PRAGMA journal_mode = ' . $journal_mode );\n"
+              "\t\t}\n"
+              "\t}"
+          )
+          new_jm = (
+              "\t\tif ( $journal_mode && in_array( $journal_mode, self::SQLITE_JOURNAL_MODES, true ) ) {\n"
+              "\t\t\t$this->query( 'PRAGMA journal_mode = ' . $journal_mode );\n"
+              "\t\t}\n"
+              "\n"
+              "\t\t// Force in-memory temp store under Turso. The default disk-backed\n"
+              "\t\t// temp pager has a state-dependent `short read on page N` bug that\n"
+              "\t\t// breaks testCreateTemporaryTable mid-suite.\n"
+              "\t\t$this->query( 'PRAGMA temp_store = MEMORY' );\n"
+              "\t}"
+          )
+          assert old_jm in src, 'connection __construct journal_mode block not found'
+          src = src.replace(old_jm, new_jm, 1)
+          open(path, 'w').write(src)
+          print('patched connection setup to set PRAGMA temp_store = MEMORY')
           PY
 
       - name: Run PHPUnit tests against Turso DB