Add multi-PHP, environment labels, and commit tracking. - #333
Conversation
Rebase PR 212 onto current master while keeping setup_runner_env_vars, and apply the requested review feedback for directory names, executable parsing, and commits.json. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@desrosj and @jazzsequence will you guys please take a look at this? TY! |
|
One of my original issues with #212 was that it contained a lot that was unrelated to adding support for multiple versions of PHP, or having a commit queue. I had created #256 and extracted all the documentation changes. It was a bit stale, so I've gone and fixed all the conflicts. I think it makes the most sense to review and merge that first. And then considering this PR. |
Ports the WPT_LABEL feature from upstream PR WordPress#333 (dilipom13:fix/212-multi-php-env-commits) into the Pantheon fork so each PHP/MariaDB matrix combination reports distinctly to WordPress.org instead of colliding under a single reporting account. - functions.php: parse WPT_LABEL into runner config; add label to get_env_details() for upstream parity - prepare.php: inject the label into the env.json generator written on the Pantheon container - report.php: surface the label in the GHA step summary - tests.yml: set WPT_LABEL=pantheon-php{XY}-db{ZZ} per matrix combination - .env.default: document WPT_LABEL (docs only; CI sets it via the workflow) The upstream multi-PHP-executable mechanism is intentionally not ported: Pantheon pins one PHP version per environment, so multi-version testing is handled by the multidev matrix (php{XY}-db{ZZ}) instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Tested this on a real Bluehost shared host (cPanel, our "Rock" server image) and it works. I ran the full prepare → test → report cycle through the new multi-PHP path (
The multi-PHP handling did what it should: three separate prepare/test/report passes, each with its own versioned prepare/test directory and its own DB table prefix, so the runs stay isolated within one invocation. Commit selection and |
chrisdavidmiles
left a comment
chrisdavidmiles
left a comment
There was a problem hiding this comment.
Approving — I tested the multi-PHP flow end-to-end on a Bluehost server (cPanel / "Rock" image), PHP 8.2 / 8.3 / 8.4, and it all passed cleanly. Full run details in my comment.
Resolve conflicts with documentation updates from WordPress#256 while keeping multi-PHP, environment labels, and commit tracking. Co-authored-by: Cursor <cursoragent@cursor.com>
5 participants
Rebase PR #212 onto current master while keeping setup_runner_env_vars, and apply the requested review feedback for directory names, executable parsing, and commits.json.