Fix UnicodeDecodeError when parsing WordPress titles containing emoji - #5589
Open
ak5869 wants to merge 1 commit into
Open
Fix UnicodeDecodeError when parsing WordPress titles containing emoji#5589ak5869 wants to merge 1 commit into
ak5869 wants to merge 1 commit into
Conversation
openverse-bot
added
🧱 stack: catalog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1550 by @aelhaddadi715-beep
Description
lxml.html.fromstringraises aUnicodeDecodeErrorwhen parsing WordPressphoto titles that contain certain emoji, causing the title to be silently
dropped (set to
None) instead of saved.This adds a fallback: when the
UnicodeDecodeErroris caught, the title isinstead cleaned using a regex-based HTML tag strip, which operates on the
original string and never re-encodes it — so the emoji is preserved
correctly.
Testing Instructions
Run the WordPress provider tests:
just test tests/dags/providers/provider_api_scripts/test_wordpress.pyA new test,
test_get_title_handles_emoji, covers a title containing anemoji and confirms it comes through unchanged.
Checklist
Update index.md).main) or a parent feature branch.