Skip to content

First stab at supporting Gutenberg projects - #7

Closed
adamziel wants to merge 1 commit into
create-prfrom
gutenberg-contribution
Closed

First stab at supporting Gutenberg projects #7
adamziel wants to merge 1 commit into
create-prfrom
gutenberg-contribution

Conversation

@adamziel

@adamziel adamziel commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

wip

juanmaguitar added a commit that referenced this pull request Aug 7, 2026
- git:apply-patch rejects a sitePath that is not a registered site before
  writing anything, the same gate sites:set-ticket uses (#8).
- Persisting the revert record is now part of the apply transaction: if the
  store write fails the apply is undone, and if that also fails the result
  says the patch is applied-but-untracked rather than reporting a clean
  failure (#7).
- git:preview-patch surfaces a worktree-inspection failure instead of
  reporting "no collisions" when it could not look (#9).
- git:discard-changes clears the applied-patch record with the reset, so a
  later trunk-update network failure cannot leave a revert banner for a
  patch that is already gone (#6).
- git:apply-patch is now a WIRED handler with real tests (guard, reverse
  lookup, delegation, done event, metadata) via fakeSettingsStore, instead
  of a NOT_REACHABLE hole (#13).

Not gating git:preview-patch: it is read-only, and the registered-site
check would add a store dependency to a handler that has none.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
juanmaguitar added a commit that referenced this pull request Aug 7, 2026
The #7 transactional branch — undo the apply when the revert record cannot
be saved, and report applied-but-untracked when that undo also fails — had
no coverage. Drive store.set to throw and assert both outcomes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@juanmaguitar

Copy link
Copy Markdown
Collaborator

Closing as superseded. This branch predates the current architecture by ~100 commits — it targets the old single-project layout and the pre-modularisation main.js/index.jsx, so it isn't revivable as code. The intent behind it is sound, though, and is now captured fresh against today's trunk in #251. Thanks for the early sketch — it's what confirmed the idea was worth doing properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants