Describe what the toolkit does at 1.0 in the README - #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v1.0.0is published, but the repository's front page still describes the app as it was atv0.1.x: a thing that sets up a development environment with no prerequisites, full stop. Nothingthat 1.0 is actually about appears on it — linking a Trac ticket, reading its facts, applying the
pull requests and patches already on it, holding work for several tickets in one site, debugging,
or sending a change back as a pull request, a Trac attachment or a mentor handoff.
### Whyhad the same problem in argument form: it makes the case against setup friction, which isthe wall
v0.1.xremoved, and stops there.Someone arriving from the Make announcement or from the release page reads this file first. It was
underselling the release they had just heard about.
What changes
README.md. The top of the file only; every section about contributing to this repository —Build from source,App icon,Why Electron?,Ideas and future work,Download stats,Contributing,License— is current and untouched.guarantees that are easy to miss and hard to re-derive: nothing installed on the host, and no push
credential written to disk.
### Whykeeps the Contributor-Day setup argument as it was and adds the second wall: a newcomerwith a running environment still has to find the existing patch, get it into the checkout,
understand a failed apply, and work out that WordPress reviews on Trac but takes pull requests on
GitHub.
already documents it, so the README stays a map and the guide stays the manual.
the patch screen that 1.0 reworked. Their thumbnails,
docs/setup-start.pnganddocs/create-patch.png, are deleted with them — the README was their only reference.site-view.png, served from the docs site. This was notasked for: removing two images and adding none leaves the page worse, and this is the image the
release notes and the announcement both open with. Say so if you would rather the README carried
no image.
package.json.descriptionwasElectron app to setup WordPress develop structure and run npm install. electron-builder carries this into the packaged application's metadata, so it isuser-visible, and it described a subset of
v0.1.x. It now describes the app. No other fieldchanges.
Not in this PR, for JuanMa to apply in Settings: the GitHub repository description is still
"An experiment to explore an easy to install core WordPress development environment app". Proposed
replacement, same sentence as the new
package.jsondescription:How to test this
Platforms: any; this is documentation and package metadata.
Run
npm run lintandnpm test.Run
npm run docs:build.docs/referenced the twodeleted images. It does not validate the README's links:
README.mdis not part of thedocs source tree, and the links are absolute external URLs, which
ignoreDeadLinksdoes notreach. Step 3 is what checks those.
From the repository root, confirm every guide page the README links actually exists:
ok.View
README.mdrendered on this branch on GitHub.it opens a real guide page rather than a 404.
Run
node -p "require('./package.json').description".What must not have happened: no source file, workflow or build configuration in the diff; the
version and every dependency unchanged.
Risks and limitations
The main risk in a change like this is a claim that reads well and is not true. Every capability
listed was checked against the guide page it links and against the shipped behaviour rather than
against memory; the review below covers that specifically.
The screenshot is hotlinked from the docs site rather than committed, so it tracks whatever the
shots harness last published. That keeps it from going stale silently, at the cost of depending on
Pages being up — the same trade the release notes make.
The new
descriptionis 163 characters. It reaches the AppImage and deb.desktopComment, thedeb control
Descriptionand the snapdescription; no length ceiling is hit and no build breaks.Snap's 78-character limit applies to
summary, which electron-builder fills fromproductName.One cosmetic consequence: Debian's
lintianwarnsdescription-too-longon a synopsis over 80characters, so the
.debpicks up a warning it did not have before. Not a build failure, notuser-visible.
Related
Follows
v1.0.0(#343, #344).Review outcome (required — see AGENTS.md)
0 [fix here] · 0 [follow-up]. No findings across architecture, security, performance,cross-platform or tests.
npm run lint,npm test(1,027/1,027) andnpm run docs:buildpass.Because the risk in this change is a claim that reads well and is false, the review was pointed at
the claims themselves. Each was traced to code, not to memory:
githubTokeninsrc/main.js:775,cleared at
:783, passed by value intosrc/github-pr.cjs. Nostore.set, no keychain, no filewrite.
src/patch-apply.jsvalidates before writing. The one path that does write is a rollback after a disk error mid-write
(
src/patch-apply.js:526-530), which is a write failure rather than a patch that will not apply;the guide draws the line in the same place.
src/ticket-branches.js:4-23.src/wp-debug-constants.js:47sets
WP_DISABLE_FATAL_ERROR_HANDLER: true.src/script-runner.js:26,36spawnprocess.execPath;src/npm-runner.js:88setsELECTRON_RUN_AS_NODE=1.src/patch-provenance.cjs.src/trunk-update.js:269-273,depth: 1.src/renderer/update-plan.cjs:144skips the build when the watcher is live.src/trac-ticket-info.cjs:133-142.Also verified: no doc page, workflow, issue template or
scripts/screenshots/entry referencedeither deleted PNG or either YouTube URL; every guide target exists; and the extensionless link form
is what the file already used on
trunkand what Pages resolves through its.htmlfallback.The review corrected one claim in this PR's own test plan:
npm run docs:builddoes not validatethe README's links, because
README.mdis not in the docs source tree and the links are absoluteexternal URLs. Step 2 above has been rewritten to say so, and step 3 is what actually checks them.