Make the agent instructions canonical in AGENTS.md - #126
Closed
juanmaguitar wants to merge 1 commit into
Closed
Conversation
juanmaguitar
force-pushed
the
remove-ci-ai-review
branch
from
August 6, 2026 07:49
e052d04 to
10c5d3b
Compare
juanmaguitar
force-pushed
the
add-agents-md
branch
from
August 6, 2026 07:54
6a85dbc to
03234fa
Compare
CLAUDE.md was the only place the project's constraints were written down, so every agent other than Claude Code started from nothing — on a codebase whose whole premise (zero host prerequisites, no git binary, one persistence layer) is invisible from the code alone. AGENTS.md is now canonical and CLAUDE.md points at it, keeping only what is genuinely Claude Code specific. AGENTS.md also carries the directive to run the review before opening a pull request, and is explicit that nothing enforces it. No Copilot file: the review standard already sits at a path Copilot reads natively, and everything else here is something it can be pointed at. Adding one would have meant a second copy of the invariants with nothing keeping the two in step. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
juanmaguitar
force-pushed
the
remove-ci-ai-review
branch
from
August 6, 2026 07:59
10c5d3b to
64c8b36
Compare
juanmaguitar
force-pushed
the
add-agents-md
branch
from
August 6, 2026 07:59
03234fa to
64e8ee7
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #125 — review that first. This diff shows only its own changes once #125 lands.
Why
CLAUDE.mdwas the only place this project's constraints were written down, so every agent other than Claude Code started from nothing. That matters more here than in most repos: the premise — zero host prerequisites, nogitbinary,electron-storeas the only persistence layer — is invisible from the code alone, and an agent that does not know it will reach forspawn('git')and be pleased with the result.What changes
AGENTS.mdis now canonical and tool-neutral. It carries whatCLAUDE.mdheld, plus the directive to run the review before opening a pull request and summarise the outcome in the description.CLAUDE.mdshrinks to a pointer plus the one genuinely Claude Code specific line, so there is no second copy to drift.No Copilot file
An earlier version of this PR added
.github/copilot-instructions.md, because Copilot reads neitherAGENTS.mdnorCLAUDE.md. It is gone: #125 puts the review standard at.github/instructions/code-review.instructions.md, which Copilot reads natively, and that is the part it actually needs. Everything else here is context an agent can be pointed at.Adding one anyway would have meant a second copy of the invariants with nothing keeping the two in step — the failure mode this PR exists to remove, reintroduced one file over.
Notes
AGENTS.mdsays plainly that nothing enforces the pre-PR review. It is a directive, and describing it as anything firmer would be false — worth keeping that way when the next person edits it.No stubs for Codex or Cursor: both read
AGENTS.mdalready, and per-tool files drift. Worth adding one when a tool is actually in use, not before.Self-review
Documentation only, no JavaScript changed.
npm run lintclean, 147 tests pass. No findings across the five dimensions.