Repository navigation
Conversation
…ding-Community#806) The /admin nav item was labeled 'Dashboard' instead of 'Home', and the 'Mentor Dashboard' link was shown to any ADMIN user. Now the label reads 'Home' and the link only renders for users holding the MENTOR role. Updates AdminLayout.test.tsx acceptance scenarios to match.
|
|
@p3xz Thanks for picking this issue. Can you please include screenshots for local testing as well, please? |
|
@p3xz Will you please upload screenshots for us to unblock merging? |
|
@p3xz Adding screenshots and explaining how you can seed other types of member data. Steps for setting up seed data - refer here (Run the all dependent applications with Docker) After the change, when a MENTORSHIP ADMIN is logged in (who is not a MENTOR) After the change, when a MENTOR is logged in @Sowmiya07 - Can you confirm the behaviour for the MENTORSHIP page ( the user i logged in is mentorship-admin@wcc.dev, having role MENTORSHIP_ADMIN. As per the message can be a PLATFORM_LEADER , but when logging as leader@wcc.dev user with LEADER role, this page does not come for the LEADER role. (so we might need to fix the backend role for /recommendation API or allow Mentorship nav for LEADER role 
|
This branch has not been deployed
3 participants
Fixes #806
Two small bugs in the admin nav bar:
/adminwas labeled "Dashboard"; it now reads "Home".ADMINuser. It is now gated on theMENTORrole only (isMentor), so an ADMIN without the MENTOR role no longer sees it.Also updates
AdminLayout.test.tsxacceptance scenarios: ADMIN-only users must not see "Mentor Dashboard", and the no-roles scenario asserts the/^home$/ilabel.Verified:
npx jest __tests__/components/AdminLayout.test.tsxpasses 5/5; the updated scenarios fail against the old component (2 failures), confirming the tests capture the bug.tsc --noEmitis clean.