Repository navigation
task: Add Adhoc Note to New Mentee Notification Email - #799
Merged
Sowmiya07 merged 5 commits intoOct 13, 2026
Merged
Conversation
Sowmiya07
requested review from
OlenaReukova,
Tooonia,
dricazenck,
goelsonali,
lauracabtay,
nora-weisser and
nverbic
September 29, 2026 12:45
7 tasks
goelsonali
reviewed
Oct 5, 2026
dricazenck
reviewed
Oct 5, 2026
dricazenck
reviewed
Oct 5, 2026
dricazenck
reviewed
Oct 5, 2026
|
Contributor
Author
|
@dricazenck @goelsonali This is ready now!! |
goelsonali
approved these changes
Oct 12, 2026
goelsonali
left a comment
goelsonali
left a comment
Contributor
There was a problem hiding this comment.
@Sowmiya07 Looks cleaner now with separate template, may be can create a clean-up issue to manage the templates within subfolders. Happy to merge this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ad hoc Note added to New Mentee Application Notification Email
This PR adds a note in the New Mentee Application Notification Email to the Mentor to let them know that it's not an error that they would receive an email but won't see any applications in the dashboard when they log in.
This is because mentees can apply to multiple mentors, and the applications accepted by one mentor will remove the application from the same mentee for the cycle from other mentors' queues.
Also, this PR adds the InvalidMentorshipTypeException to GlobalExceptionHandler
Closes #779
Long Term
Ad Hoc
Exception Handling Before vs After