optimize CompoundTag map compares#701
Open
hayanesuru wants to merge 2 commits into
Open
Conversation
HaHaWTH
requested changes
Apr 10, 2026
|
|
||
| @Override | ||
| public CompoundTag copy() { | ||
| + // Leaf start - Further reduce memory footprint of CompoundTag | ||
| + if (this.tags instanceof org.dreeam.leaf.util.map.StringCanonizingOpenHashMap<Tag> stringCanonizingTags) { | ||
| + return new CompoundTag(org.dreeam.leaf.util.map.StringCanonizingOpenHashMap.deepCopy(stringCanonizingTags, Tag::copy)); | ||
| + org.dreeam.leaf.util.map.StringCanonizingOpenHashMap<Tag> ret = new org.dreeam.leaf.util.map.StringCanonizingOpenHashMap<>(stringCanonizingTags.size(), 0.8f); |
Member
There was a problem hiding this comment.
I'm curious about how much improvement this patch can bring, as we ignored the load factor of the original map when copying, rehashing cost is expensive.
I suggest add another method getLoadFactor in the StringCanonizingOpenHashMap to reuse load factor
| final Map<?, ?> m = (Map<?, ?>)o; | ||
| if (m.size() != size()) return false; | ||
| if (containsNullKey) { | ||
| if (!value[n].equals(m.get(key[n]))) { |
Member
There was a problem hiding this comment.
Should we use Objects.equals here to guard against null values? And use m.containsKey(key) to ensure the key exists, null == null is always true
kyssta-exe
pushed a commit
to kyssta-exe/Lumora
that referenced
this pull request
Jun 3, 2026
Upstream has released updates that appear to apply and compile correctly Leaves Changes: LeavesMC/Leaves@08bfa446 Lithium Sleeping Block Entity（Winds-Studio#618） (Winds-Studio#630) LeavesMC/Leaves@610eee60 fix: fix bot resume CME (Winds-Studio#635) LeavesMC/Leaves@04dac366 Fix vanilla display name (Winds-Studio#638) LeavesMC/Leaves@e5aba7eb feat: hopper counter unlimited speed(Winds-Studio#625) (Winds-Studio#639) LeavesMC/Leaves@e44e469a fix: fix SleepingBlockEntity crash when /tick freeze (Winds-Studio#640) LeavesMC/Leaves@5d653e31 fix: fix faster chunk serialization patch (Winds-Studio#641) LeavesMC/Leaves@cb6cd658 [ci/skip] chore: fix patch header LeavesMC/Leaves@8d9a5b2f [ci/skip]chore: rename hopper counter enable config (Winds-Studio#644) LeavesMC/Leaves@cc019e8f [ci/skip] feat: add Bukkit.getFeatureManager api (Winds-Studio#645) LeavesMC/Leaves@81da0c5e [ci/skip] Bring back LivingEntity effect CME (Winds-Studio#648) LeavesMC/Leaves@ea91106a fix: fix hopper counter config (Winds-Studio#646) LeavesMC/Leaves@230e0987 feat: mount action(Winds-Studio#619) (Winds-Studio#649) LeavesMC/Leaves@d9f7afc4 fix: fix sleeping block entity(Winds-Studio#654) (Winds-Studio#655) LeavesMC/Leaves@12f665c0 Refactor actions (Winds-Studio#650) LeavesMC/Leaves@c29ff9a8 feat: swap action (Winds-Studio#657) LeavesMC/Leaves@3c09044e fix: fix grindstone curse book overstacking(Winds-Studio#658) (Winds-Studio#659) LeavesMC/Leaves@e05f3f7c Update paper, revert Winds-Studio#632 (Winds-Studio#662) LeavesMC/Leaves@0c866281 Bot Improvements (Winds-Studio#661) LeavesMC/Leaves@956f0227 feat: add skipTripwireHookPlacementValidation to mc-technical-mode, and format config (Winds-Studio#664) LeavesMC/Leaves@e047327c fix: fix bot use raytrace (Winds-Studio#669) LeavesMC/Leaves@29327349 Fix Winds-Studio#667 (Winds-Studio#668) LeavesMC/Leaves@08f53c97 Fix bot cant get entity tracker (Winds-Studio#670) LeavesMC/Leaves@e0d62b4e fix photographer bugs (Winds-Studio#666) LeavesMC/Leaves@d094bdad fix: fix raid(Winds-Studio#626) (Winds-Studio#671) LeavesMC/Leaves@678d4e20 Revert "Fix bot cant get entity tracker (Winds-Studio#670)" LeavesMC/Leaves@e298d097 [ci/skip] fix: fix patch name (Winds-Studio#672) LeavesMC/Leaves@099be5b8 [ci/skip] fix: fix push to api fail when commit contains double quotation marks (Winds-Studio#677) LeavesMC/Leaves@ba8993d3 Fix fakeplayer cant get entity tracker correctly (Winds-Studio#676) LeavesMC/Leaves@d93e9766 feat: merge old raid config, fix bugs (Winds-Studio#680) LeavesMC/Leaves@bf55b2a4 fix: fix sleeping block entity bug (Winds-Studio#682) LeavesMC/Leaves@5366b382 Fix creative no clip with projectile (Winds-Studio#683) LeavesMC/Leaves@e55edbf8 Resolves Winds-Studio#685 (Winds-Studio#687) LeavesMC/Leaves@a591ec57 Do not tick Arrow life regardless (Winds-Studio#688) LeavesMC/Leaves@3623aea8 fix: stupid me (Winds-Studio#689) LeavesMC/Leaves@73e63912 feat: update leavesclip to 3.0.7 (Winds-Studio#681) LeavesMC/Leaves@bb5a1dff [ci/skip] fix: fix comment (Winds-Studio#692) LeavesMC/Leaves@d87bc544 Fix Winds-Studio#690 (Winds-Studio#691) LeavesMC/Leaves@79d9ef74 Update paper (Winds-Studio#693) LeavesMC/Leaves@71790286 Fix optimize noise generation LeavesMC/Leaves@3ffbde0b Optimize config transfer and remove LeavesMC/Leaves@62e62242 feat: add logger for internal plugin, and format api code (Winds-Studio#696) LeavesMC/Leaves@f37e9d37 Fix fakeplayer break action LeavesMC/Leaves@aeb8e07d Fix fakeplayer break action * 2 LeavesMC/Leaves@40af0399 Fix StackableShulker config validator LeavesMC/Leaves@122c7365 Fix fakeplayer use action LeavesMC/Leaves@0ee80784 fix: fix photographer bugs (Winds-Studio#699) LeavesMC/Leaves@a30c9abb Remove, and opt config and config command LeavesMC/Leaves@4b21a968 New shears wrench (Winds-Studio#700) LeavesMC/Leaves@0f40159c Enhance update suppression (Winds-Studio#701) LeavesMC/Leaves@374605cd Fix bot (Winds-Studio#705) LeavesMC/Leaves@ff563baf Fix creative no clip can attract xp-orb (Winds-Studio#706) LeavesMC/Leaves@f0de3ecd refactor: use client side judgement instead of special judgement (Winds-Studio#708)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#646
avoid map entry and iterator overhead
inline
StringCanonizingOpenHashMap#deepCopy