Vanilla forum embedding#54
Open
NattyNarwhal wants to merge 1 commit into
Open
Conversation
|
On vanillaForumEmbed.ejs, are the footer that says "Discussions by Vanilla" and the link to Vanilla's main site in the |
Contributor
Author
|
1. it's the default thing I copied in from Vanilla2. It's on a branch I haven't merged into master as it still has issues, not terribly relevant. Sent from my BlackBerry From: notifications@github.comSent: May 22, 2018 11:31 AMTo: adventure@noreply.github.comReply to: reply@reply.github.comCc: calvin@cmpct.info; author@noreply.github.comSubject: Re: [WinWorldPC/adventure] Vanilla forum embedding (#54) On vanillaForumEmbed.ejs, are the footer that says "Discussions by Vanilla" and the link to Vanilla's main site in the<noscript> tag really necessary? I remember that the old phpBB forum never had "Powered by phpBB" in the footer.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discuss with Duff/SG first.