Input ring: fix overflows and random drops along with xservermenu reattach #603
Open
Xnick417x wants to merge 2 commits into
Open
Input ring: fix overflows and random drops along with xservermenu reattach #603Xnick417x wants to merge 2 commits into
Xnick417x wants to merge 2 commits into
Conversation
- Publish ring events and state snapshots with a store-store fence so the guest-side reader can no longer observe the sequence word before the payload it publishes; unfenced stores could surface as rare random stale or lost inputs under load. - Grow the per-slot event ring 512 -> 4096 events so a stalled reader loses history far later; a press/release pair inside the overwritten window was silently dropped. - Restage libfakeinput.so into the imagefs on every launch so the guest reader can never run against a newer ring layout than it understands.
While the menu drawer is open it consumes all controller events for navigation, so a release performed there never reaches the input service: the guest keeps the input applied while the menu is open, and the delta-encoded writer then swallows the next press of that same button because its tracked state never saw the release. Zero every connected controller's tracked state and push it once on drawer open so the guest releases everything and post-close presses register again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.