Repository navigation
Build with Stonecutter, one node per Minecraft version - #31
Merged
Merged
Conversation
Prepares builds for several Minecraft versions from the same sources. For now the only node is 26.2; the jar's version names the Minecraft release it is for. Unit tests run in every node, so the parity tests check against that version's vanilla. Formatting moves to google-java-format, since Spotless can't run on a Stonecutter root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
The build targets one Minecraft version. Supporting 26.1.x and 26.3 next to 26.2 needs one jar per version, built from the same sources with small version seams.
The build now uses Stonecutter 0.9.8, as Lacmus does:
versions/<version>, built bybuild.fabric.gradle.kts. For now there is only26.2; 26.3 and 26.1.x follow in their own PRs.stonecutter.properties.toml.fabric.mod.json: it is filled in from those values.1.0.0+26.2, so the jars for different versions can be told apart. The file is nowtrajectory-projected-1.0.0+26.2.jar.src/testand run in every node. The parity tests compare the core with the real vanilla classes, so each node checks against its own Minecraft version../gradlew formatandformatCheck, because Spotless can't run on a Stonecutter root. The CI job keeps its name,spotless.Nothing changes in the mod itself.
Validation performed
./gradlew formatCheck build: 105 unit tests pass in node 26.2.fabric.mod.jsondiffers only in the version,1.0.0→1.0.0+26.2;modsfolder, alone and with the add-on: both pass, with the add-on jar in the folder.-PwithIrisbrings in Sodium 0.9.2 and Iris 1.11.4 for local runs.Limits and compatibility