Repository navigation
Draw the line after the level, so water no longer tints it - #29
Merged
Merged
Conversation
The line went into the level's own submits, and water is drawn after them. It is now always drawn after the level render, as it already was with a shader pack, depth-tested against the main depth buffer. AfterShaders is renamed AfterLevel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Without a shader pack, water tinted the line blue: the dots, the ghost bobber and the ring over water. The line went into the level's own submits, and water is drawn after them. With improved transparency on, water is also composed separately at the end of the frame.
The line is now always drawn after the level render, onto the finished image and depth-tested against the main depth buffer. Until now this path was used only with an Iris shader pack. So:
AfterShadersis renamedAfterLevelto match. With a shader pack nothing changes.Validation performed
./gradlew spotlessApply buildpasses.Limits and compatibility