Skip to content

Take the pose an animation ends on from vanilla - #43

Merged
WilyFoxM merged 1 commit into
mainfrom
fix/exact-resting-pose
Nov 5, 2026
Merged

WilyFoxM merged 1 commit into
mainfrom
fix/exact-resting-pose

Conversation

@WilyFoxM

@WilyFoxM WilyFoxM commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Problem and resulting behavior

The full native suite for 1.6.0 found that a display at the end of its animation could differ from vanilla by two edge pixels (standalone and Sodium + ImmediatelyFast; Sodium + Iris passed). The direct pose (#42) matches vanilla's only to float rounding: the rest matrix is derived through an inverse, and an error of about 1e-6 is enough to give an edge pixel to the neighboring face. The per-frame pose check, at a tolerance of 1e-4, does not catch that.

  • The direct pose is now used only while a part is still interpolating. The pose an animation ends on comes from vanilla once and is then reused by the existing cache, so a model at rest is drawn from exactly vanilla's matrices.
  • Cost: one vanilla submit per part at the end of each animation.

During an animation the direct pose can still differ from vanilla by float rounding, which may move an edge pixel for a frame.

Validation performed

  • GitHub checks (build, unit-tests, spotless): pending on this PR.
  • Local checks actually run (configuration and result):
    • ./gradlew spotlessApply build (JDK 25.0.4): passes.
    • LivePoseFastClientTest, LiveDisplaySceneClientTest and LiveViewCullingClientTest, full mode, standalone, Sodium + ImmediatelyFast and Sodium + Iris 1.11.4 with shaders off: all pass. The end of the animation now matches a fresh vanilla capture with a largest per-channel difference of 0, where it was 2 pixels with a difference of up to 83 before. 960 per-frame pose checks per run, no mismatch; all 16 parts still take the direct path while animating.
    • The full native suite runs again on the release branch after this merges.
  • Rendering screenshots / benchmark evidence, where relevant: none; the change affects only the last frame of each animation.

Limits and compatibility

Pixel equality is checked at rest only. In motion, the comparison remains the per-frame matrix and normal check.

The direct pose matches vanilla only to float rounding, which moved two
edge pixels of a resting model in the full native suite. Use it only
while a part interpolates; the resting pose comes from vanilla once and
is then reused.
@WilyFoxM
WilyFoxM merged commit 13dfb14 into main Nov 5, 2026
6 checks passed
@WilyFoxM
WilyFoxM deleted the fix/exact-resting-pose branch November 5, 2026 19:40
@WilyFoxM WilyFoxM mentioned this pull request Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant