Repository navigation
Take the pose an animation ends on from vanilla - #43
Merged
Merged
Conversation
The direct pose matches vanilla only to float rounding, which moved two edge pixels of a resting model in the full native suite. Use it only while a part interpolates; the resting pose comes from vanilla once and is then reused.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
The full native suite for 1.6.0 found that a display at the end of its animation could differ from vanilla by two edge pixels (standalone and Sodium + ImmediatelyFast; Sodium + Iris passed). The direct pose (#42) matches vanilla's only to float rounding: the rest matrix is derived through an inverse, and an error of about 1e-6 is enough to give an edge pixel to the neighboring face. The per-frame pose check, at a tolerance of 1e-4, does not catch that.
During an animation the direct pose can still differ from vanilla by float rounding, which may move an edge pixel for a frame.
Validation performed
./gradlew spotlessApply build(JDK 25.0.4): passes.LivePoseFastClientTest,LiveDisplaySceneClientTestandLiveViewCullingClientTest, full mode, standalone, Sodium + ImmediatelyFast and Sodium + Iris 1.11.4 with shaders off: all pass. The end of the animation now matches a fresh vanilla capture with a largest per-channel difference of 0, where it was 2 pixels with a difference of up to 83 before. 960 per-frame pose checks per run, no mismatch; all 16 parts still take the direct path while animating.Limits and compatibility
Pixel equality is checked at rest only. In motion, the comparison remains the per-frame matrix and normal check.