Repository navigation
Skip Item Displays outside the view - #41
Merged
Merged
Conversation
Parts already on the GPU whose bounds lie outside this frame's view are skipped before extraction, while their ticks and animation keep running. A new setting controls it, ON by default, and the add-on gains a live_culling benchmark target.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Item Displays usually have a zero-size culling box, so vanilla does not test them against the view: everything in range is extracted, captured, uploaded and drawn, including what is behind the camera.
live_cullingbenchmark target in the add-on, and per-frameculledcounters in the Live geometry diagnostic.A part moving very quickly into view may appear a moment late; the setting's description says so.
Validation performed
./gradlew spotlessApply build(JDK 25.0.4): passes, with 43 local JUnit tests.LiveViewCullingClientTest(new),LiveDisplaySceneClientTest,LiveExtractionSceneClientTest,StaticDisplaySceneClientTest,TextAndLiveSceneClientTest,FeatureBatchLiveClientTest,DisplayModelBudgetClientTest,DisplayProbeClientTest,BenchmarkSeriesClientTest,DrawLessSettingsClientTest,ItemMeshEvictionClientTest,DisplayMembershipClientTest,ObservationClientTest,IrisShaderPackClientTest.LiveViewCullingClientTest: of 16 Item Displays in a ring at FOV 70, 11 are skipped. Screenshots match OFF after a turn, after moving a skipped display into view and after giving one a new pose. The comparison covers the area above the hand and tolerates up to 8 per channel for sky fading after joining, so it would catch a missing or misplaced part, not subtle pixel changes. It uses plain cubes, not animated models.The OFF range is about the size of the gain, so read this as roughly 3 to 4% on this scene. I also turned the camera quickly between ModelEngine NPCs with the option on and didn't notice anything unusual; that is an observation, not pixel parity.
Limits and compatibility
One scene and one session. GPU time was not measured, and a crowded scene was not measured; with many players, Item Displays are a smaller part of the frame, so the percentage is likely lower. Fast animations of large models and models far from their entity position were not tested. While an Iris shader pack is active Live geometry is paused, so nothing is skipped. Parts on the ordinary path are not skipped. Saved configurations without this option get the new default ON.