Repository navigation
fix: check the CrowdSec diagnostics paths against the data folder properly - #1563
Merged
Merged
Conversation
…perly The CrowdSec diagnostics now confirm the config and acquisition files are really inside the data folder, so a neighbouring folder whose name merely starts the same way is no longer accepted. Reuses the existing path containment helper, and its tests now also cover names such as "..foo" being accepted while real parent traversal is rejected. Closes #1541 Co-authored-by: AdamMagued <AdamMagued@users.noreply.github.com>
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Wikid82
marked this pull request as ready for review
October 11, 2026 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two path checks in the CrowdSec diagnostics config handler now use the existing
pathWithinhelper instead of a string-prefix test, so a sibling folder such as<data dir>_siblingcan no longer pass. ExtrapathWithincases cover a..fooname (accepted), real parent traversal and a sibling folder (rejected).This takes over #1543 (opened against
main; the ReadFile/WriteFile hunks were already moved ondevelopment). The original idea is credited with aCo-authored-bytrailer.Verification
go test ./internal/api/handlers/... -run 'Diagnostics|PathWithin|Crowdsec' -count=2passes; fullgolangci-linton the handlers package clean.Issue #1541 is already closed.
Claude Code helped produce this change.