Repository navigation
test: make the CrowdSec and handler tests repeatable in one process - #1553
Merged
Merged
Conversation
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the
internal/crowdsecandinternal/api/handlersbackend tests repeatable in one process (go test -count>1,-shuffle), and adds a cheap guard and a weekly check so it stays that way. This is unrelated test infrastructure; it does not change application code.Closes #1548. Refs #1278 (the repo-wide shared-cache DSN problem; other packages stay tracked there).
Cause
Many tests built a shared-cache in-memory SQLite name from
t.Name()(file:<name>?mode=memory&cache=shared). That database lives as long as one connection to the name is open, so the second iteration of-count=2reopened the first iteration's data (UNIQUE constraint failed, and a panic atTestAuthHandler_GetAccessibleHosts_PermittedHosts). The issue understated it: 12internal/crowdsectests (includingTestHeartbeatPoller_StatusTransition) and 28+ handler tests failed.Changes
testutil.MemoryDSN/OpenMemoryDB(takingtesting.TB): a name never used before in the process, parameters appended, pool closed on cleanup.handlers.OpenTestDBnow uses it.cache=sharedliteral appears in the two clean packages' test files (red/green demonstrated).go test -race -count=2 -shuffle=<seed>over the two packages. Not a required check. About 18 minutes measured (one handlers iteration is about 7 minutes under-race); 60 minute test timeout, 75 minute job timeout.codecov.ymlignores only the new helper file.Testing
-race -count=3and-shuffle=on -count=2on both packages green (handlers-count=2829 s,-count=31268 s; crowdsec-count=3316 s).docs/reports/qa_report.md.Notes
main; useworkflow_dispatchto run it sooner.cache=sharedtest lines remain elsewhere, tracked in test: shared-cache in-memory SQLite DSN collisions under -race + t.Parallel() (101+ sites) #1278).