Repository navigation
fix: slim down the CrowdSec export, validate imports by parsing, and fix import UI text - #1542
Merged
Merged
Conversation
The export now contains configuration only, and importing an export from a real install works again. Imports keep the running server's own connection details and roll back without touching them.
Imported configuration is now parsed as YAML instead of being matched by text, and any upload that is not a .tar.gz archive gets one clear message.
The import picker no longer suggests ZIP files, and the Check Now buttons use the translation files in every supported language.
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
require_ci_to_pass was at the top level, which Codecov rejects, so the whole file was ignored and default coverage targets were used.
Post codecov.yml to Codecov's validator so an invalid file (which Codecov silently ignores wholesale) fails CI. Validation errors fail the check; an unreachable validator only warns. Adds bats coverage with a stubbed curl.
Wikid82
marked this pull request as ready for review
October 10, 2026 14:01
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to #1535 for the CrowdSec configuration export and import. Plan lived outside the repo for this batch.
Closes #1532, closes #1533, closes #1534
data/, database files), so the download is just configuration. The walk now keeps sibling files correctly when it skips an entry.config/. A sharedFindConfigFilehelper now finds it everywhere the code looked for it. A failed import rolls back without touching the kept entries (RestoreKeeping), and preset apply follows the same skip rule..tar.gzupload gets one clear message; the upload picker offers only.tar.gz; the two hardcoded "Check Now" buttons are translated in all five locales.Intentional tightening
config.yamlare now rejected, and a merge key (<<:) at the top level is rejected too. This is stricter than CrowdSec's own loader.disable_agent) is rejected.Known limitations (tracked)
Testing
go test -raceon the crowdsec package and on the import/export/rollback handler tests; full golangci-lint config clean (backend and agent).--project=security-tests(194 tests, no fixme).docs/reports/qa_report.md) found no critical, high or medium issues; includes an alias-expansion probe of the new parser.