Repository navigation
fix: validate CrowdSec archive entry names with a standard local-path check - #1536
Merged
Merged
Conversation
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A local CodeQL Go scan reported a new
go/zipslipresult inextractTarGz(backend/internal/crowdsec/hub_sync.go) after #1535. That PR replaced aHasPrefix(name, "..")guard with a custom helper (to accept names such as..foo), and CodeQL cannot see through a custom helper.Entry names are now checked with the standard
filepath.IsLocalbefore they reach the path join. Behaviour is unchanged for real archives:..foo,a/..b,./a.txtare accepted;../x,a/../../xand absolute paths are rejected. One edge case differs: an empty entry name is now rejected instead of cleaning to.. The containment check, symlink-safe file creation and engine-owned-path skip are unchanged.Testing
go test ./internal/crowdsec/...,go vet, full golangci-lint config: clean../directory entries,./a.txtand the empty-name case.