Skip to content

fix(security): harden outbound client configuration in notification senders - #1492

Merged
Wikid82 merged 7 commits into
developmentfrom
fix/notification-sender-client-hardening
Oct 6, 2026
Merged

Wikid82 merged 7 commits into
developmentfrom
fix/notification-sender-client-hardening

Conversation

@Wikid82

@Wikid82 Wikid82 commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Summary

Hardens the outbound client configuration used by the notification senders so the production path no longer enables a testing-only allowance. The allowance now sits behind an unexported test-only seam shared by both senders, which also removes the duplicated client construction.

Behaviour note

Notification webhooks can no longer target loopback addresses (localhost, 127.0.0.1, ::1). A receiver running on the same host must be reached via a non-loopback address (LAN IP or Docker hostname). Documented in docs/features/notifications.md.

Testing

  • Regression tests cover default rejection and the test-only seam
  • go test -race ./internal/services/..., go test ./internal/api/..., make lint-fast pass
  • Backend coverage 92.3%; patch coverage 100%
  • QA report: docs/reports/qa_report.md

Built with help from Claude Code.

@codecov

codecov Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

✅ Supply Chain Verification Results

✅ PASSED

📦 SBOM Summary

  • Components: 1870

🔍 Vulnerability Scan

Severity Count
🔴 Critical 0
🟠 High 0
🟡 Medium 0
🟢 Low 0
Total 0

📎 Artifacts

  • SBOM (CycloneDX JSON) and Grype results available in workflow artifacts

Generated by Supply Chain Verification workflow • View Details

@github-advanced-security

Copy link
Copy Markdown
Contributor

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@Wikid82
Wikid82 merged commit 8f5095a into development Oct 6, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants