chore: propagate changes from main into development - #1372
Merged
Merged
Conversation
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Wikid82
added a commit
that referenced
this pull request
Sep 21, 2026
A merge commit (e.g. the nightly -> main weekly promotion) can leave a branch "ahead" by that commit while its resulting tree is identical to the target branch, since the content already arrived there via another path. The existing ahead_by===0 guard doesn't catch this, so a no-op PR gets opened (PR #1372: 0 files changed). Skip creation when the actual file diff is empty, regardless of ahead_by.
The weekly nightly->main promotion's health check only looked at completed workflow runs and gave up after ~2 minutes of polling, so an E2E run still in progress (real runtime ~20min) was indistinguishable from one that never started, producing false-negative "unhealthy" verdicts and blocking promotion. Separately, trigger-required-checks existed to dispatch missing required workflows but was gated behind create-promotion-pr, which only runs when the branch is already healthy - so it could never fire in exactly the case where a missing E2E/CodeQL run was the problem. Rewrite the health check to poll up to 40 minutes with no status filter (so in-progress runs are visible), and to self-dispatch missing E2E/CodeQL runs on the nightly HEAD directly instead of depending on the deadlocked downstream job. Quality Checks has no workflow_dispatch trigger, so it is never dispatched - if still missing at the deadline that's treated as a real failure, not a timing artifact. Trim the now-redundant E2E/CodeQL entries from trigger-required-checks.
A merge commit (e.g. the nightly -> main weekly promotion) can leave a branch "ahead" by that commit while its resulting tree is identical to the target branch, since the content already arrived there via another path. The existing ahead_by===0 guard doesn't catch this, so a no-op PR gets opened (PR #1372: 0 files changed). Skip creation when the actual file diff is empty, regardless of ahead_by.
Contributor
Author
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Wikid82
marked this pull request as ready for review
September 21, 2026 22:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/plans/current_spec.mdAutomated PR to propagate changes from main into development.
Triggered by push to main.